mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: "Wim Van Sebroeck" <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: lenovo_se30g2_se60_wdt: Watchdog for Lenovo SE30G2 and SE60
Date: Wed, 24 Jun 2026 10:21:16 -0400	[thread overview]
Message-ID: <4662b2ae-c30a-4e0e-ad6a-db7935a0a75f@app.fastmail.com> (raw)
In-Reply-To: <6c516e9a-1dad-4c02-aedb-52168806bd21@roeck-us.net>

On Tue, Jun 23, 2026, at 10:21 PM, Guenter Roeck wrote:
> On 6/22/26 07:45, Mark Pearson wrote:
>> Watchdog driver implementation for Lenovo SE30G2 and SE60 platforms.
>> 
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> ---
> ...
>> +static int wdt_set_timeout(struct watchdog_device *wdog, unsigned int timeout)
>> +{
>> +	if (timeout < MIN_TIMEOUT || timeout > MAX_TIMEOUT)
>> +		return -EINVAL;
>> +
> Unnecessary range check. Unnecessary call, actually.
> See watchdog_dev.c:watchdog_set_timeout().
>
Agreed - will remove.
Thanks for the review

Mark

      reply	other threads:[~2026-06-24 14:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 14:45 Mark Pearson
2026-06-24  2:21 ` Guenter Roeck
2026-06-24 14:21   ` Mark Pearson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4662b2ae-c30a-4e0e-ad6a-db7935a0a75f@app.fastmail.com \
    --to=mpearson-lenovo@squebb.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®