From: Guenter Roeck <linux@roeck-us.net>
To: Mark Pearson <mpearson-lenovo@squebb.ca>
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: lenovo_se30g2_se60_wdt: Watchdog for Lenovo SE30G2 and SE60
Date: Tue, 23 Jun 2026 19:21:27 -0700 [thread overview]
Message-ID: <6c516e9a-1dad-4c02-aedb-52168806bd21@roeck-us.net> (raw)
In-Reply-To: <20260622144531.2413447-1-mpearson-lenovo@squebb.ca>
On 6/22/26 07:45, Mark Pearson wrote:
> Watchdog driver implementation for Lenovo SE30G2 and SE60 platforms.
>
> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> ---
...
> +static int wdt_set_timeout(struct watchdog_device *wdog, unsigned int timeout)
> +{
> + if (timeout < MIN_TIMEOUT || timeout > MAX_TIMEOUT)
> + return -EINVAL;
> +
Unnecessary range check. Unnecessary call, actually.
See watchdog_dev.c:watchdog_set_timeout().
Guenter
next prev parent reply other threads:[~2026-06-24 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 14:45 Mark Pearson
2026-06-24 2:21 ` Guenter Roeck [this message]
2026-06-24 14:21 ` Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c516e9a-1dad-4c02-aedb-52168806bd21@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®