From: Wangao Wang <wangao.wang@oss.qualcomm.com>
To: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: wangao.wang@oss.qualcomm.com, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
quic_qiweil@quicinc.com, quic_renjiang@quicinc.com
Subject: Re: [PATCH v4 2/6] media: qcom: iris: Improve crop_offset handling for encoder
Date: Mon, 10 Nov 2025 10:37:19 +0800 [thread overview]
Message-ID: <46637f07-f6dd-4a9d-aa52-0ba12b571c29@oss.qualcomm.com> (raw)
In-Reply-To: <1728c571-1e25-59e2-beae-124d9976fb3f@oss.qualcomm.com>
On 2025/11/7 18:25, Dikshita Agarwal wrote:
>
>
> On 11/6/2025 9:00 AM, Wangao Wang wrote:
>> The setting of HFI_PROP_CROP_OFFSETS for the OUTPUT port is correct,
>> but on the CAPTURE port it is used to inform the firmware about the
>> ROI, so crop_offset needs to be handled accordingly.
>>
>> Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
>
> Does CROP use case work with just this patch and first one?
>
> Since you are enabling different features in your series, pls make sure
> features are working with individual patches.
>
> Thanks,
> Dikshita
>> ---
The crop for the input port works correctly with just these two patches.
--
Best Regards,
Wangao
next prev parent reply other threads:[~2025-11-10 2:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 3:30 [PATCH v4 0/6] media: qcom: iris: encoder feature enhancements Wangao Wang
2025-11-06 3:30 ` [PATCH v4 1/6] media: qcom: iris: Improve format alignment for encoder Wangao Wang
2025-11-07 8:42 ` Dikshita Agarwal
2025-11-10 2:34 ` Wangao Wang
2025-11-06 3:30 ` [PATCH v4 2/6] media: qcom: iris: Improve crop_offset handling " Wangao Wang
2025-11-07 10:25 ` Dikshita Agarwal
2025-11-10 2:37 ` Wangao Wang [this message]
2025-11-06 3:30 ` [PATCH v4 3/6] media: qcom: iris: Add scale support " Wangao Wang
2025-11-06 3:30 ` [PATCH v4 4/6] media: qcom: iris: Add rotation " Wangao Wang
2025-11-07 8:45 ` Dikshita Agarwal
2025-11-06 3:30 ` [PATCH v4 5/6] media: qcom: iris: Add flip " Wangao Wang
2025-11-07 8:46 ` Dikshita Agarwal
2025-11-06 3:30 ` [PATCH v4 6/6] media: qcom: iris: Add intra refresh " Wangao Wang
2025-11-07 9:05 ` Dikshita Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46637f07-f6dd-4a9d-aa52-0ba12b571c29@oss.qualcomm.com \
--to=wangao.wang@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_qiweil@quicinc.com \
--cc=quic_renjiang@quicinc.com \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®