From: Wangao Wang <wangao.wang@oss.qualcomm.com>
To: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: wangao.wang@oss.qualcomm.com, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
quic_qiweil@quicinc.com, quic_renjiang@quicinc.com
Subject: Re: [PATCH v4 1/6] media: qcom: iris: Improve format alignment for encoder
Date: Mon, 10 Nov 2025 10:34:59 +0800 [thread overview]
Message-ID: <e72f3d55-9d1a-4e10-b9f6-5f1162064982@oss.qualcomm.com> (raw)
In-Reply-To: <df169cde-39db-ec6c-7294-04939575498b@oss.qualcomm.com>
On 2025/11/7 16:42, Dikshita Agarwal wrote:
>
>> @@ -231,8 +230,8 @@ static int iris_hfi_gen2_set_crop_offsets(struct iris_inst *inst, u32 plane)
>> top_offset = inst->compose.top;
>> }
>> } else {
>> - bottom_offset = (inst->fmt_src->fmt.pix_mp.height - inst->crop.height);
>> - right_offset = (inst->fmt_src->fmt.pix_mp.width - inst->crop.width);
>> + bottom_offset = (inst->fmt_dst->fmt.pix_mp.height - inst->enc_raw_height);
>> + right_offset = (inst->fmt_dst->fmt.pix_mp.width - inst->enc_raw_width);
>
> This should be move to 2nd patch where you clean the CROP offset property
> setting.
>
It will be modified in v5.
--
Best Regards,
Wangao
next prev parent reply other threads:[~2025-11-10 2:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 3:30 [PATCH v4 0/6] media: qcom: iris: encoder feature enhancements Wangao Wang
2025-11-06 3:30 ` [PATCH v4 1/6] media: qcom: iris: Improve format alignment for encoder Wangao Wang
2025-11-07 8:42 ` Dikshita Agarwal
2025-11-10 2:34 ` Wangao Wang [this message]
2025-11-06 3:30 ` [PATCH v4 2/6] media: qcom: iris: Improve crop_offset handling " Wangao Wang
2025-11-07 10:25 ` Dikshita Agarwal
2025-11-10 2:37 ` Wangao Wang
2025-11-06 3:30 ` [PATCH v4 3/6] media: qcom: iris: Add scale support " Wangao Wang
2025-11-06 3:30 ` [PATCH v4 4/6] media: qcom: iris: Add rotation " Wangao Wang
2025-11-07 8:45 ` Dikshita Agarwal
2025-11-06 3:30 ` [PATCH v4 5/6] media: qcom: iris: Add flip " Wangao Wang
2025-11-07 8:46 ` Dikshita Agarwal
2025-11-06 3:30 ` [PATCH v4 6/6] media: qcom: iris: Add intra refresh " Wangao Wang
2025-11-07 9:05 ` Dikshita Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e72f3d55-9d1a-4e10-b9f6-5f1162064982@oss.qualcomm.com \
--to=wangao.wang@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_qiweil@quicinc.com \
--cc=quic_renjiang@quicinc.com \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®