From: Tobias Oed <tobias.oed@octant-fr.com>
To: jmorris@namei.org
Cc: tobias.oed@octant-fr.com, sds@tycho.nsa.gov, trivial@kernel.org,
linux-kernel@vger.kernel.org
Subject: [RESENT][TRIVIAL][PATCH] SELinux: Use %lu for inode->i_no when printing avcs
Date: Mon, 11 Jun 2007 12:29:45 +0200 [thread overview]
Message-ID: <466D2419.7040106@octant-fr.com> (raw)
Resending this to a wider audience since the first attempt was mangled
and I haven't heard anything in a week.
Inode numbers are unsigned long and so need to %lu as format string of
printf. I have no idea why the __attribute__((format,..)) of
audit_log_format
doesn't give us a warning.
Compile tested only.
Signed-off-by: Tobias Oed <tobias.oed@octant-fr.com>
--- linux-2.6.21.3/security/selinux/avc.c.orig 2007-06-11
12:19:28.000000000 +0200
+++ linux-2.6.21.3/security/selinux/avc.c 2007-06-04
21:19:22.000000000 +0200
@@ -584,7 +584,7 @@ void avc_audit(u32 ssid, u32 tsid,
}
}
if (inode)
- audit_log_format(ab, " dev=%s ino=%ld",
+ audit_log_format(ab, " dev=%s ino=%lu",
inode->i_sb->s_id,
inode->i_ino);
break;
next reply other threads:[~2007-06-11 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 10:29 Tobias Oed [this message]
2007-06-11 13:06 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466D2419.7040106@octant-fr.com \
--to=tobias.oed@octant-fr.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®