* [RESENT][TRIVIAL][PATCH] SELinux: Use %lu for inode->i_no when printing avcs
@ 2007-06-11 10:29 Tobias Oed
2007-06-11 13:06 ` James Morris
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Oed @ 2007-06-11 10:29 UTC (permalink / raw)
To: jmorris; +Cc: tobias.oed, sds, trivial, linux-kernel
Resending this to a wider audience since the first attempt was mangled
and I haven't heard anything in a week.
Inode numbers are unsigned long and so need to %lu as format string of
printf. I have no idea why the __attribute__((format,..)) of
audit_log_format
doesn't give us a warning.
Compile tested only.
Signed-off-by: Tobias Oed <tobias.oed@octant-fr.com>
--- linux-2.6.21.3/security/selinux/avc.c.orig 2007-06-11
12:19:28.000000000 +0200
+++ linux-2.6.21.3/security/selinux/avc.c 2007-06-04
21:19:22.000000000 +0200
@@ -584,7 +584,7 @@ void avc_audit(u32 ssid, u32 tsid,
}
}
if (inode)
- audit_log_format(ab, " dev=%s ino=%ld",
+ audit_log_format(ab, " dev=%s ino=%lu",
inode->i_sb->s_id,
inode->i_ino);
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RESENT][TRIVIAL][PATCH] SELinux: Use %lu for inode->i_no when printing avcs
2007-06-11 10:29 [RESENT][TRIVIAL][PATCH] SELinux: Use %lu for inode->i_no when printing avcs Tobias Oed
@ 2007-06-11 13:06 ` James Morris
0 siblings, 0 replies; 2+ messages in thread
From: James Morris @ 2007-06-11 13:06 UTC (permalink / raw)
To: Tobias Oed; +Cc: sds, trivial, linux-kernel
On Mon, 11 Jun 2007, Tobias Oed wrote:
> Resending this to a wider audience since the first attempt was mangled
> and I haven't heard anything in a week.
>
> Inode numbers are unsigned long and so need to %lu as format string of
> printf. I have no idea why the __attribute__((format,..)) of
> audit_log_format
> doesn't give us a warning.
> Compile tested only.
>
> Signed-off-by: Tobias Oed <tobias.oed@octant-fr.com>
Thanks, tested & applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-11 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-11 10:29 [RESENT][TRIVIAL][PATCH] SELinux: Use %lu for inode->i_no when printing avcs Tobias Oed
2007-06-11 13:06 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®