* [PATCH] drm/vmwgfx: remove unused vmw_overlay function
@ 2023-03-21 18:24 Tom Rix
2023-04-07 17:40 ` Nick Desaulniers
2023-04-11 17:54 ` Zack Rusin
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-21 18:24 UTC (permalink / raw)
To: zackr, linux-graphics-maintainer, airlied, daniel, nathan, ndesaulniers
Cc: dri-devel, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:56:35: error:
unused function 'vmw_overlay' [-Werror,-Wunused-function]
static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev)
^
This function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
index 8d171d71cb8a..7e112319a23c 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
@@ -53,12 +53,6 @@ struct vmw_overlay {
struct vmw_stream stream[VMW_MAX_NUM_STREAMS];
};
-static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev)
-{
- struct vmw_private *dev_priv = vmw_priv(dev);
- return dev_priv ? dev_priv->overlay_priv : NULL;
-}
-
struct vmw_escape_header {
uint32_t cmd;
SVGAFifoCmdEscape body;
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/vmwgfx: remove unused vmw_overlay function
2023-03-21 18:24 [PATCH] drm/vmwgfx: remove unused vmw_overlay function Tom Rix
@ 2023-04-07 17:40 ` Nick Desaulniers
2023-04-11 17:54 ` Zack Rusin
1 sibling, 0 replies; 3+ messages in thread
From: Nick Desaulniers @ 2023-04-07 17:40 UTC (permalink / raw)
To: Tom Rix
Cc: zackr, linux-graphics-maintainer, airlied, daniel, nathan,
dri-devel, linux-kernel, llvm
On Tue, Mar 21, 2023 at 11:24 AM Tom Rix <trix@redhat.com> wrote:
>
> clang with W=1 reports
> drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:56:35: error:
> unused function 'vmw_overlay' [-Werror,-Wunused-function]
> static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
> index 8d171d71cb8a..7e112319a23c 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
> @@ -53,12 +53,6 @@ struct vmw_overlay {
> struct vmw_stream stream[VMW_MAX_NUM_STREAMS];
> };
>
> -static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev)
> -{
> - struct vmw_private *dev_priv = vmw_priv(dev);
> - return dev_priv ? dev_priv->overlay_priv : NULL;
> -}
> -
> struct vmw_escape_header {
> uint32_t cmd;
> SVGAFifoCmdEscape body;
> --
> 2.27.0
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/vmwgfx: remove unused vmw_overlay function
2023-03-21 18:24 [PATCH] drm/vmwgfx: remove unused vmw_overlay function Tom Rix
2023-04-07 17:40 ` Nick Desaulniers
@ 2023-04-11 17:54 ` Zack Rusin
1 sibling, 0 replies; 3+ messages in thread
From: Zack Rusin @ 2023-04-11 17:54 UTC (permalink / raw)
To: daniel, nathan, ndesaulniers, Linux-graphics-maintainer, trix, airlied
Cc: dri-devel, llvm, linux-kernel
On Tue, 2023-03-21 at 14:24 -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:56:35: error:
> unused function 'vmw_overlay' [-Werror,-Wunused-function]
> static inline struct vmw_overlay *vmw_overlay(struct drm_device *dev)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Thank you for the patch. I went ahead and pushed it to the drm-misc-next branch in
drm-misc tree.
z
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-11 17:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-21 18:24 [PATCH] drm/vmwgfx: remove unused vmw_overlay function Tom Rix
2023-04-07 17:40 ` Nick Desaulniers
2023-04-11 17:54 ` Zack Rusin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®