Re: [1/2] 2.6.22-rc5: known regressions with patches

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Arjan van de Ven wrote:
> --- linux-2.6.22-rc5/arch/i386/Kconfig.debug.org	2007-06-20 22:20:30.000000000 -0700
> +++ linux-2.6.22-rc5/arch/i386/Kconfig.debug	2007-06-20 22:20:55.000000000 -0700
> @@ -49,7 +49,6 @@ config DEBUG_PAGEALLOC
>  config DEBUG_RODATA
>  	bool "Write protect kernel read-only data structures"
>  	depends on DEBUG_KERNEL
> -	depends on !KPROBES # temporary for 2.6.22
>  	help
>  	  Mark the kernel read-only data as write-protected in the pagetables,
>  	  in order to catch accidental (and incorrect) writes to such const
> --- linux-2.6.22-rc5/arch/x86_64/Kconfig.debug.org	2007-06-20 22:20:28.000000000 -0700
> +++ linux-2.6.22-rc5/arch/x86_64/Kconfig.debug	2007-06-20 22:20:44.000000000 -0700
> @@ -9,7 +9,6 @@ source "lib/Kconfig.debug"
>  config DEBUG_RODATA
>         bool "Write protect kernel read-only data structures"
>         depends on DEBUG_KERNEL
> -       depends on !KPROBES # temporary for 2.6.22
>         help
>  	 Mark the kernel read-only data as write-protected in the pagetables,
>  	 in order to catch accidental (and incorrect) writes to such const data.

Shouldn't we add something to the help texts?

+	This option also marks kernel text pages as write-protected,
+	except if you enable KPROBES.

CMIIW.

As mentioned elsewhere in this thread, replacing CONFIG_DEBUG_RODATA by
CONFIG_WRITEPROTECT_RODATA and CONFIG_WRITEPROTECT_TEXT might be a
better idea.  The latter should be mutual exclusive with CONFIG_KPROBES.
-- 
Stefan Richter
-=====-=-=== -==- =-=-=
http://arcgraph.de/sr/