mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ian McDonald <ian.mcdonald@jandi.co.nz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Miklos Szeredi <miklos@szeredi.hu>, Ingo Molnar <mingo@elte.hu>,
	"Darrick J. Wong" <djwong@us.ibm.com>, Andi Kleen <ak@suse.de>,
	Bj?rn Steinbrink <B.Steinbrink@gmx.de>,
	William Cohen <wcohen@redhat.com>,
	"S. P. Prasanna" <prasanna@in.ibm.com>,
	Antonino Daplas <adaplas@gmail.com>, Olaf Hering <olaf@aepfle.de>,
	Ville Syrj?l? <syrjala@sci.fi>, Jean Delvare <khali@linux-fr.org>,
	Rudolf Marek <r.marek@assembler.cz>,
	Soeren Sonnenburg <kernel@nn7.de>,
	Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Subject: Re: [1/2] 2.6.22-rc5: known regressions with patches
Date: Wed, 20 Jun 2007 15:54:37 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.98.0706201550480.3593@woody.linux-foundation.org> (raw)
In-Reply-To: <5640c7e00706201541g3ecaf8c5i524d8b464d8fcc2d@mail.gmail.com>



On Thu, 21 Jun 2007, Ian McDonald wrote:
> 
> It depends on the purpose of DEBUG_RODATA.  If DEBUG_RODATA was for
> security reasons then I agree, but it seems to be more to catch
> accidental writes.

Well, I'd say that it is *one* tool for debugging.

Now, Kprobes is another tool - and I'm just saying that I don't see why 
you should really expect to break one tool with the other. They take 
different approaches.

And yes, sometimes debugging *does* change what it debugs. In timing, if 
nothing else, but also in the kinds of things you can do. For example, we 
don't allow slab redzoning on data structures that have alignment 
restrictions not compatible with the redzoning, and I'd argue that this is 
more of the same: we just should not do DEBUG_RODATA if you expect to 
change read-only data.

There's just no *point*. 

		Linus

  reply	other threads:[~2007-06-20 22:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-17 14:23 Michal Piotrowski
2007-06-17 15:16 ` Ingo Molnar
2007-06-17 15:31   ` Michal Piotrowski
2007-06-20 22:08 ` Ian McDonald
2007-06-20 22:31   ` Chuck Ebbert
2007-06-20 22:38     ` Ian McDonald
2007-06-20 22:41     ` Linus Torvalds
2007-06-20 22:38   ` Linus Torvalds
2007-06-20 22:41     ` Ian McDonald
2007-06-20 22:54       ` Linus Torvalds [this message]
2007-06-20 23:02         ` Ian McDonald
2007-06-20 23:04         ` Linus Torvalds
2007-06-21 15:46           ` Chuck Ebbert
2007-06-20 23:07     ` Dave Jones
2007-06-20 23:15       ` Arjan van de Ven
2007-06-20 23:24         ` Dave Jones
2007-06-20 23:48       ` Linus Torvalds
2007-06-21  9:19         ` [PATCH] Alternative fix for kprobes&DEBUG_RODATA was " Andi Kleen
2007-06-21 16:03           ` Linus Torvalds
2007-06-20 23:21     ` Arjan van de Ven
2007-06-20 23:50       ` Linus Torvalds
2007-06-21  5:23         ` Arjan van de Ven
2007-06-21  7:11           ` S. P. Prasanna
2007-06-21 14:35           ` Stefan Richter
2007-06-21 14:36             ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.98.0706201550480.3593@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=B.Steinbrink@gmx.de \
    --cc=adaplas@gmail.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=djwong@us.ibm.com \
    --cc=ian.mcdonald@jandi.co.nz \
    --cc=kernel@nn7.de \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=miklos@szeredi.hu \
    --cc=mingo@elte.hu \
    --cc=olaf@aepfle.de \
    --cc=prasanna@in.ibm.com \
    --cc=r.marek@assembler.cz \
    --cc=syrjala@sci.fi \
    --cc=wcohen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®