Re: [PATCH V2] LoongArch: Introduce the numa_memblks conversion

["Yuquan Wang" <wangyuquan1236@phytium.com.cn>]

> -----原始邮件-----
> 发件人: "Huacai Chen" <chenhuacai@kernel.org>
> 发送时间:2025-04-19 15:57:16 (星期六)
> 收件人: "Mike Rapoport" <rppt@kernel.org>
> 抄送: "Huacai Chen" <chenhuacai@loongson.cn>, loongarch@lists.linux.dev, "Xuefeng Li" <lixuefeng@loongson.cn>, "Guo Ren" <guoren@kernel.org>, "Xuerui Wang" <kernel@xen0n.name>, "Jiaxun Yang" <jiaxun.yang@flygoat.com>, linux-kernel@vger.kernel.org, "Binbin Zhou" <zhoubinbin@loongson.cn>, "Yuquan Wang" <wangyuquan1236@phytium.com.cn>
> 主题: Re: [PATCH V2] LoongArch: Introduce the numa_memblks conversion
> 
> Hi, Mike,
> 
> On Sat, Apr 19, 2025 at 3:48 PM Mike Rapoport <rppt@kernel.org> wrote:
> >
> > Hi Huacai,
> >
> > On Tue, Apr 15, 2025 at 03:21:18PM +0800, Huacai Chen wrote:
> > > Commit 87482708210ff3333a ("mm: introduce numa_memblks") has moved
> > > numa_memblks from x86 to the generic code, but LoongArch was left out
> > > of this conversion.
> > >
> > > This patch introduces the generic numa_memblks for LoongArch.
> > >
> > > In detail:
> > > 1. Enable NUMA_MEMBLKS (but disable NUMA_EMU) in Kconfig;
> > > 2. Use generic definition for numa_memblk and numa_meminfo;
> > > 3. Use generic implementation for numa_add_memblk() and its friends;
> > > 4. Use generic implementation for numa_set_distance() and its friends;
> > > 5. Use generic implementation for memory_add_physaddr_to_nid() and its
> > >    friends.
> > >
> > > Note: Disable NUMA_EMU because it needs more efforts and no obvious
> > > demand now.
> > >
> > > Tested-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > > Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
> > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> > > ---
> > >  arch/loongarch/Kconfig                 |   1 +
> > >  arch/loongarch/include/asm/numa.h      |  14 ----
> > >  arch/loongarch/include/asm/sparsemem.h |   5 --
> > >  arch/loongarch/include/asm/topology.h  |   7 +-
> > >  arch/loongarch/kernel/acpi.c           |  11 ---
> > >  arch/loongarch/kernel/numa.c           | 108 +++----------------------
> > >  arch/loongarch/mm/init.c               |   8 --
> > >  mm/Kconfig                             |   1 +
> > >  8 files changed, 16 insertions(+), 139 deletions(-)
> >
> > This is really cool simplification!
> >
> > I wonder if maybe we can take a step or two further and make loongarch to
> > share more code with other architectures.
> >
> > Is there a strong reason not to call numa_memblks_init() from
> > init_numa_memory()?
> > And more broadly, maybe loongarch can be even switched to arch_numa?
> This is a minimal change for Yuquan, I will make it in linux-next as
> soon as possible so Yuquan can continue his work.
> 
Hi, Huacai & Mike

Where could I know this has been merged in linux-next? After that, should I
re-push the commit "introduce numa_add_reserved_memblk" ?

Sorry for my unfamiliarity with the community rules.

Yuquan

> Switching to numa_memblks_init() or arch_numa will be done in future,
> but need some time because some machines seem to need some hacks.
> 
> Huacai
> 
> >
> > --
> > Sincerely yours,
> > Mike.


信息安全声明：本邮件包含信息归发件人所在组织所有,发件人所在组织对该邮件拥有所有权利。请接收者注意保密,未经发件人书面许可,不得向任何第三方组织和个人透露本邮件所含信息。
Information Security Notice: The information contained in this mail is solely property of the sender's organization.This mail communication is confidential.Recipients named above are obligated to maintain secrecy and are not permitted to disclose the contents of this communication to others.