From: Mike Rapoport <rppt@kernel.org>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
loongarch@lists.linux.dev, Xuefeng Li <lixuefeng@loongson.cn>,
Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-kernel@vger.kernel.org,
Binbin Zhou <zhoubinbin@loongson.cn>,
Yuquan Wang <wangyuquan1236@phytium.com.cn>
Subject: Re: [PATCH V2] LoongArch: Introduce the numa_memblks conversion
Date: Sat, 19 Apr 2025 10:48:01 +0300 [thread overview]
Message-ID: <aANVMaepni3KeABI@kernel.org> (raw)
In-Reply-To: <20250415072118.3774454-1-chenhuacai@loongson.cn>
Hi Huacai,
On Tue, Apr 15, 2025 at 03:21:18PM +0800, Huacai Chen wrote:
> Commit 87482708210ff3333a ("mm: introduce numa_memblks") has moved
> numa_memblks from x86 to the generic code, but LoongArch was left out
> of this conversion.
>
> This patch introduces the generic numa_memblks for LoongArch.
>
> In detail:
> 1. Enable NUMA_MEMBLKS (but disable NUMA_EMU) in Kconfig;
> 2. Use generic definition for numa_memblk and numa_meminfo;
> 3. Use generic implementation for numa_add_memblk() and its friends;
> 4. Use generic implementation for numa_set_distance() and its friends;
> 5. Use generic implementation for memory_add_physaddr_to_nid() and its
> friends.
>
> Note: Disable NUMA_EMU because it needs more efforts and no obvious
> demand now.
>
> Tested-by: Binbin Zhou <zhoubinbin@loongson.cn>
> Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> arch/loongarch/Kconfig | 1 +
> arch/loongarch/include/asm/numa.h | 14 ----
> arch/loongarch/include/asm/sparsemem.h | 5 --
> arch/loongarch/include/asm/topology.h | 7 +-
> arch/loongarch/kernel/acpi.c | 11 ---
> arch/loongarch/kernel/numa.c | 108 +++----------------------
> arch/loongarch/mm/init.c | 8 --
> mm/Kconfig | 1 +
> 8 files changed, 16 insertions(+), 139 deletions(-)
This is really cool simplification!
I wonder if maybe we can take a step or two further and make loongarch to
share more code with other architectures.
Is there a strong reason not to call numa_memblks_init() from
init_numa_memory()?
And more broadly, maybe loongarch can be even switched to arch_numa?
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2025-04-19 7:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 7:21 Huacai Chen
2025-04-19 7:48 ` Mike Rapoport [this message]
2025-04-19 7:57 ` Huacai Chen
2025-04-27 1:35 ` Yuquan Wang
2025-05-06 1:57 ` Huacai Chen
2025-05-06 1:22 ` Yuquan Wang
2025-05-06 2:02 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aANVMaepni3KeABI@kernel.org \
--to=rppt@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=guoren@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=wangyuquan1236@phytium.com.cn \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®