mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: xiujianfeng <xiujianfeng@huawei.com>
To: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <rostedt@goodmis.org>,
	<mingo@redhat.com>
Subject: Re: [PATCH] rv/monitor: add __init/__exit annotations to module init/exit funcs
Date: Thu, 22 Sep 2022 18:37:52 +0800	[thread overview]
Message-ID: <468b3d61-a1a9-a49b-b737-c2d39ca22a4e@huawei.com> (raw)
In-Reply-To: <d0c8336b-bdaa-8e57-38fa-f570c3d696b8@kernel.org>

Hi,

在 2022/9/22 17:25, Daniel Bristot de Oliveira 写道:
> Hi Xiu
> 
> The first char after the subsys: must be capital, i.e.,
> 
> [PATCH] rv/monitor: Add __init/__exit annotations to module init/exit funcs
> 
> On 9/11/22 05:04, Xiu Jianfeng wrote:
>> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Please, also add these tags to the monitor templates here:
> 
> 
> tools/verification/dot2/dot2k_templates/main_global.c
> tools/verification/dot2/dot2k_templates/main_per_cpu.c
> tools/verification/dot2/dot2k_templates/main_per_task.c
> 
> So the fix is propagated to future monitors.

Thanks for the review, will do in v2.

> 
> Thanks
> -- Daniel
> .
> 

      reply	other threads:[~2022-09-22 10:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-11  3:04 Xiu Jianfeng
2022-09-22  9:25 ` Daniel Bristot de Oliveira
2022-09-22 10:37   ` xiujianfeng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468b3d61-a1a9-a49b-b737-c2d39ca22a4e@huawei.com \
    --to=xiujianfeng@huawei.com \
    --cc=bristot@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®