mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Xiu Jianfeng <xiujianfeng@huawei.com>
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, mingo@redhat.com
Subject: Re: [PATCH] rv/monitor: add __init/__exit annotations to module init/exit funcs
Date: Thu, 22 Sep 2022 11:25:39 +0200	[thread overview]
Message-ID: <d0c8336b-bdaa-8e57-38fa-f570c3d696b8@kernel.org> (raw)
In-Reply-To: <20220911030418.94609-1-xiujianfeng@huawei.com>

Hi Xiu

The first char after the subsys: must be capital, i.e.,

[PATCH] rv/monitor: Add __init/__exit annotations to module init/exit funcs

On 9/11/22 05:04, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.

Please, also add these tags to the monitor templates here:


tools/verification/dot2/dot2k_templates/main_global.c
tools/verification/dot2/dot2k_templates/main_per_cpu.c
tools/verification/dot2/dot2k_templates/main_per_task.c

So the fix is propagated to future monitors.

Thanks
-- Daniel

  reply	other threads:[~2022-09-22  9:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-11  3:04 Xiu Jianfeng
2022-09-22  9:25 ` Daniel Bristot de Oliveira [this message]
2022-09-22 10:37   ` xiujianfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0c8336b-bdaa-8e57-38fa-f570c3d696b8@kernel.org \
    --to=bristot@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=xiujianfeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®