mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chan, Genevieve" <genevieve.chan@altera.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dinh Nguyen <dinguyen@kernel.org>,
	Lothar Rubusch <l.rubusch@gmail.com>,
	Ng Tze Yee <tzeyee.ng@altera.com>,
	Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>,
	Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: altera: add Agilex7F SoCDK multi-QSPI compatible
Date: Tue, 29 Sep 2026 21:42:11 +0800	[thread overview]
Message-ID: <468bc9e3-a93c-46c6-8cb3-2542e80c6579@altera.com> (raw)
In-Reply-To: <20260915-therapeutic-jackal-of-temperance-1ae852@quoll>

On 15/9/2026 6:49 pm, Krzysztof Kozlowski wrote:
 > On Mon, Sep 14, 2026 at 10:50:51AM +0800, Genevieve Chan wrote:
 >> From: Genevieve Chan <genevieve.chan@altera.com>
 >>
 >> Add "intel,socfpga-agilex7f-socdk-multiqspi" for the Agilex7F SoCDK
 >> board variant with multi-QSPI flash support.
 >
 > Why is agilex7f the same as agilex?

Hi Krzysztof,

It is the same SoC. The original Agilex family was renamed to
"Agilex 7" when the Agilex 5 and Agilex 3 families were introduced,
so "Agilex 7 F-Series" is the current product name of the
Agilex F-Series device. The silicon and the HPS are unchanged, which
is why the board uses socfpga_agilex.dtsi and falls back to
"intel,socfpga-agilex", like the existing Agilex SoCDK boards.

Using "agilex7f" in the board compatible creates a confusion, as it
suggests a different SoC. In v2 I will rename it to
"intel,socfpga-agilex-socdk-multiqspi" to follow the existing
"intel,socfpga-agilex-socdk" and "intel,socfpga-agilex-socdk-emmc"
entries.

 > Your commit msg is pretty redundant, just copies diff instead of
 > explaining odd things like why do you have exception from rules in
 > writing bindings.

Understood. With the fixes mentioned earlier, there will no longer be an 
exception to the naming rules. In v2 the commit message will explain how 
this board differs from the standard Agilex SoCDK (the multi-QSPI flash
population) and why it needs its own compatible, instead of
repeating the diff.

Thanks,
Genevieve

  reply	other threads:[~2026-09-29 13:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14  2:50 [PATCH 0/2] arm64: dts: socfpga: agilex: add Agilex7F SoCDK multi-QSPI board genevieve.chan
2026-09-14  2:50 ` [PATCH 1/2] dt-bindings: arm: altera: add Agilex7F SoCDK multi-QSPI compatible genevieve.chan
2026-09-15 10:49   ` Krzysztof Kozlowski
2026-09-29 13:42     ` Chan, Genevieve [this message]
2026-09-14  2:50 ` [PATCH 2/2] arm64: dts: socfpga: agilex: add Agilex7F SoCDK multi-QSPI board genevieve.chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468bc9e3-a93c-46c6-8cb3-2542e80c6579@altera.com \
    --to=genevieve.chan@altera.com \
    --cc=adrian.ho.yin.ng@altera.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=l.rubusch@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muhammad.nazim.amirul.nazle.asmade@altera.com \
    --cc=robh@kernel.org \
    --cc=tzeyee.ng@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®