From: "David Bahi" <dbahi@novell.com>
To: <linux-kernel@vger.kernel.org>, <linux-rt-users@vger.kernel.org>
Cc: <rostedt@goodmis.org>, <tglx@linutronix.de>,
"Gregory Haskins" <GHaskins@novell.com>
Subject: [PATCH 1/1] nmi_watchdog: x86_64 count timer and hpet like i386
Date: Wed, 26 Sep 2007 12:45:17 -0600 [thread overview]
Message-ID: <46FA545D0200006C0001930D@sinclair.provo.novell.com> (raw)
In-Reply-To: <46FA545D0200006C0001930D@sinclair.provo.novell.com>
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
This modifies nmi_watchdog_tick behavior for x86_64 arch to
consider both timer and pit/hpet IRQs just as the i386 arch does.
Without this fix a kernel crash occurs very early in the boot
process if nmi_watchdog is on.
Signed-off-by: David Bahi <dbahi@novell.com>
---
arch/x86_64/kernel/nmi.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
Index: linux-2.6.22.8-rt9_1267/arch/x86_64/kernel/nmi.c
===================================================================
--- linux-2.6.22.8-rt9_1267.orig/arch/x86_64/kernel/nmi.c
+++ linux-2.6.22.8-rt9_1267/arch/x86_64/kernel/nmi.c
@@ -369,8 +369,6 @@ int notrace __kprobes nmi_watchdog_tick(
touched = 1;
}
- sum = read_pda(apic_timer_irqs);
-
if (__get_cpu_var(nmi_touch)) {
__get_cpu_var(nmi_touch) = 0;
touched = 1;
@@ -386,6 +384,12 @@ int notrace __kprobes nmi_watchdog_tick(
cpu_clear(cpu, backtrace_mask);
}
+ /*
+ * Take the local apic timer and PIT/HPET into account. We don't
+ * know which one is active, when we have highres/dyntick on
+ */
+ sum = read_pda(apic_timer_irqs) + kstat_cpu(cpu).irqs[0];
+
#ifdef CONFIG_X86_MCE
/* Could check oops_in_progress here too, but it's safer
not too */
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
parent reply other threads:[~2007-09-26 18:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <46FA545D0200006C0001930D@sinclair.provo.novell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FA545D0200006C0001930D@sinclair.provo.novell.com \
--to=dbahi@novell.com \
--cc=GHaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome