From: Pan Xinhui <xinhui@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@kernel.org>,
Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, longman@redhat.com
Subject: Re: [PATCH] locking/pvqspinlock: Wait early if vcpu is preempted
Date: Thu, 5 Jan 2017 16:44:25 +0800 [thread overview]
Message-ID: <46d0cfa0-888f-648a-b31c-9b760eda3ca2@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170105082324.GF2098@gmail.com>
在 2017/1/5 16:23, Ingo Molnar 写道:
>
> * Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> wrote:
>
>> If prev node is not in runnig state or its cpu is preempted, we need
>> wait early in pv_wait_node. After commit "sched/core: Introduce the
>> vcpu_is_preempted(cpu) interface" kernel has knowledge of one vcpu is
>> running or not. So lets use it.
>
> That's not how we reference upstream commits. I had to search the git log the hard
> way to figure out that it's commit d9345c65eb79 ...
>
hi, Ingo
Sorry. Such stupid mistake will not happen next time.
> Also, once you look at that commit you'll see how sloppy the capitalization in
> your changelog is. I fixed that up for all the original commits in the hope of you
> learning from those mistakes - but that was last year and the experiment failed.
>
So sorry, I pay most attention on spelling of words. :(
Maybe I rely on the tools of ./scripts/checkpatch.pl too much.
I will rewrite the comments and resend this patch.
> Thanks,
>
> Ingo
>
prev parent reply other threads:[~2017-01-05 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 18:44 Pan Xinhui
2017-01-05 8:23 ` Ingo Molnar
2017-01-05 8:44 ` Pan Xinhui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46d0cfa0-888f-648a-b31c-9b760eda3ca2@linux.vnet.ibm.com \
--to=xinhui@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=xinhui.pan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®