From: Dave Hansen <dave.hansen@intel.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
zhang_wei@open-hieco.net, yangzhen@hygon.cn
Cc: bp@alien8.de, dave.hansen@linux.intel.com,
david.laight.linux@gmail.com, dengqiming@hygon.cn, hpa@zytor.com,
linux-kernel@vger.kernel.org, mingo@redhat.com, puwen@hygon.cn,
stable@vger.kernel.org, tglx@linutronix.de, x86@kernel.org
Subject: Re: [PATCH] x86/cpu/hygon: Work around XSAVES Erratum 1386
Date: Fri, 20 Nov 2026 07:54:06 -0800 [thread overview]
Message-ID: <46d14366-dd1f-45f4-abc3-4d9dd8c32e7b@intel.com> (raw)
In-Reply-To: <89a5aef2-ea88-43d7-adcc-3f6b7374932f@citrix.com>
On 11/20/26 07:29, Andrew Cooper wrote:
>> Third, even if we could move to XSAVEC, I'm not sure it buys us much. I
>> certainly don't want to add the complexity to our already horrid XSAVE
>> mess. The right fix is in the microcode. Let's not give our dear
>> hardware vendors to mitigate even fewer issues than they do already.
> Linux already has a mitigation for #1386. The mitigation *is* to
> pretend that XSAVES doesn't exist, which causes Linux to fall back to
> using XSAVEC.
>
> See fix_erratum_1386() in amd.c.
>
> Hygon should extend the microcode list and call that function, rather
> than opencoding it differently.
Hah, silly me. Sounds good to me.
prev parent reply other threads:[~2026-11-20 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 23:57 Tina Zhang
2026-11-19 15:28 ` Dave Hansen
2026-11-20 1:51 ` Tina Zhang
2026-11-20 9:46 ` David Laight
2026-11-20 14:12 ` Tina Zhang
2026-11-20 14:44 ` David Laight
2026-11-20 14:57 ` Dave Hansen
2026-11-20 15:29 ` Andrew Cooper
2026-11-20 15:54 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46d14366-dd1f-45f4-abc3-4d9dd8c32e7b@intel.com \
--to=dave.hansen@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david.laight.linux@gmail.com \
--cc=dengqiming@hygon.cn \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=puwen@hygon.cn \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yangzhen@hygon.cn \
--cc=zhang_wei@open-hieco.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®