mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: dave.hansen@intel.com, zhang_wei@open-hieco.net, yangzhen@hygon.cn
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	bp@alien8.de, dave.hansen@linux.intel.com,
	david.laight.linux@gmail.com, dengqiming@hygon.cn, hpa@zytor.com,
	linux-kernel@vger.kernel.org, mingo@redhat.com, puwen@hygon.cn,
	stable@vger.kernel.org, tglx@linutronix.de, x86@kernel.org
Subject: Re: [PATCH] x86/cpu/hygon: Work around XSAVES Erratum 1386
Date: Fri, 20 Nov 2026 15:29:55 +0000	[thread overview]
Message-ID: <89a5aef2-ea88-43d7-adcc-3f6b7374932f@citrix.com> (raw)
In-Reply-To: <b04950ad-d655-4ca2-8cbd-59360509d25b@intel.com>

> Could you explain how that would help, exactly?
>
> First, there needs to be a reference to the erratum in the changelog.
> For me, searching for this string git the PDF to pop out of Google:
> "Revision Guide for AMD Family 19h Models 00h-0Fh (Publication #56683)".
>
> Second, I don't see anything in the erratum that says it is triggered by
> supervisor state. Do you know something about this erratum that's not in
> the public document?
>
> I'm not even sure AMD _has_ supervisor state components on Zen 2 that
> Linux uses.
>
> Third, even if we could move to XSAVEC, I'm not sure it buys us much. I
> certainly don't want to add the complexity to our already horrid XSAVE
> mess. The right fix is in the microcode. Let's not give our dear
> hardware vendors to mitigate even fewer issues than they do already.

Linux already has a mitigation for #1386.  The mitigation *is* to
pretend that XSAVES doesn't exist, which causes Linux to fall back to
using XSAVEC.

See fix_erratum_1386() in amd.c.

Hygon should extend the microcode list and call that function, rather
than opencoding it differently.

~Andrew

  reply	other threads:[~2026-11-20 15:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 23:57 Tina Zhang
2026-11-19 15:28 ` Dave Hansen
2026-11-20  1:51   ` Tina Zhang
2026-11-20  9:46 ` David Laight
2026-11-20 14:12   ` Tina Zhang
2026-11-20 14:44     ` David Laight
2026-11-20 14:57       ` Dave Hansen
2026-11-20 15:29         ` Andrew Cooper [this message]
2026-11-20 15:54           ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89a5aef2-ea88-43d7-adcc-3f6b7374932f@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=david.laight.linux@gmail.com \
    --cc=dengqiming@hygon.cn \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=puwen@hygon.cn \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yangzhen@hygon.cn \
    --cc=zhang_wei@open-hieco.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®