[PATCH] hid/uhid: fix a double-fetch bug when copying event from user

[PATCH] hid/uhid: fix a double-fetch bug when copying event from user

[Meng Xu]

When in_compat_syscall(), a user could make type != UHID_CREATE when
get_user(type, buffer) [first fetch] and later make event->type ==
UHID_CREATE in copy_from_user(event, buffer, ...) [second fetch].

By doing so, an attacker might circumvent the specific logic to handle
the type == UHID_CREATE case and later cause undefined behaviors.

This patch enforces that event->type is overriden to the type value
copied in the first fetch and thus, mitigate this race condition attack.

Signed-off-by: Meng Xu <mengxu.gatech@gmail.com>
---
 drivers/hid/uhid.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
index 7f8ff39..4bbfd8a 100644
--- a/drivers/hid/uhid.c
+++ b/drivers/hid/uhid.c
@@ -448,11 +448,20 @@ static int uhid_event_from_user(const char __user *buffer, size_t len,
 			kfree(compat);
 			return 0;
 		}
+
 		/* All others can be copied directly */
-	}
+		if (copy_from_user(event, buffer, min(len, sizeof(*event))))
+			return -EFAULT;
 
-	if (copy_from_user(event, buffer, min(len, sizeof(*event))))
-		return -EFAULT;
+		/* 
+		 * Override type in case the user process rushes to change it 
+		 * between two fetches 
+		 * */
+		event->type = type;
+	} else {
+		if (copy_from_user(event, buffer, min(len, sizeof(*event))))
+			return -EFAULT;
+	}
 
 	return 0;
 }
-- 
2.7.4

Re: [PATCH] hid/uhid: fix a double-fetch bug when copying event from user

[Dmitry Torokhov]

On Mon, Sep 18, 2017 at 10:21 PM, Meng Xu <mengxu.gatech@gmail.com> wrote:
> When in_compat_syscall(), a user could make type != UHID_CREATE when
> get_user(type, buffer) [first fetch] and later make event->type ==
> UHID_CREATE in copy_from_user(event, buffer, ...) [second fetch].
>
> By doing so, an attacker might circumvent the specific logic to handle
> the type == UHID_CREATE case and later cause undefined behaviors.
>
> This patch enforces that event->type is overriden to the type value
> copied in the first fetch and thus, mitigate this race condition attack.

I do not believe this mitigates anything, as copy_form_user() is not
an atomic operation and we can have 2nd thread "scrambling" the memory
while 1st does the ioctl.

We also should not expect that we always get consistent data from
userspace and the rest of the driver should be able to cope with
(reject) such data.

>
> Signed-off-by: Meng Xu <mengxu.gatech@gmail.com>
> ---
>  drivers/hid/uhid.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
> index 7f8ff39..4bbfd8a 100644
> --- a/drivers/hid/uhid.c
> +++ b/drivers/hid/uhid.c
> @@ -448,11 +448,20 @@ static int uhid_event_from_user(const char __user *buffer, size_t len,
>                         kfree(compat);
>                         return 0;
>                 }
> +
>                 /* All others can be copied directly */
> -       }
> +               if (copy_from_user(event, buffer, min(len, sizeof(*event))))
> +                       return -EFAULT;
>
> -       if (copy_from_user(event, buffer, min(len, sizeof(*event))))
> -               return -EFAULT;
> +               /*
> +                * Override type in case the user process rushes to change it
> +                * between two fetches
> +                * */
> +               event->type = type;

So if we started with UHID_INPUT, userspace replaced it with
UHID_FEATURE, we clobber the type UHID_INPUT leaving the rest of the
structure holding the new data and call it a day? That does not make
any sense to me.

> +       } else {
> +               if (copy_from_user(event, buffer, min(len, sizeof(*event))))
> +                       return -EFAULT;
> +       }
>
>         return 0;
>  }
> --
> 2.7.4
>

Thanks.

-- 
Dmitry

Re: [PATCH] hid/uhid: fix a double-fetch bug when copying event from user

[Meng Xu]

On 09/19/2017 05:31 PM, Dmitry Torokhov wrote:
> On Mon, Sep 18, 2017 at 10:21 PM, Meng Xu <mengxu.gatech@gmail.com> wrote:
>> When in_compat_syscall(), a user could make type != UHID_CREATE when
>> get_user(type, buffer) [first fetch] and later make event->type ==
>> UHID_CREATE in copy_from_user(event, buffer, ...) [second fetch].
>>
>> By doing so, an attacker might circumvent the specific logic to handle
>> the type == UHID_CREATE case and later cause undefined behaviors.
>>
>> This patch enforces that event->type is overriden to the type value
>> copied in the first fetch and thus, mitigate this race condition attack.
> I do not believe this mitigates anything, as copy_form_user() is not
> an atomic operation and we can have 2nd thread "scrambling" the memory
> while 1st does the ioctl.
Yes, what you described is the root cause of this double-fetch situation
and that is why I am proposing this patch.
>
> We also should not expect that we always get consistent data from
> userspace and the rest of the driver should be able to cope with
> (reject) such data.
Yes, that is also true and we should never assume to get consistent
data from userspace. That is why in this case, we can have user
started with UHID_INPUT just to skip the large chunk of code in
if (type == UHID_CREATE) {} and then replace it with UHID_CREATE
and take the function uhid_dev_create(uhid, &uhid->input_buf).
This is exactly what this patch tries to mitigate.
>> Signed-off-by: Meng Xu <mengxu.gatech@gmail.com>
>> ---
>>   drivers/hid/uhid.c | 15 ++++++++++++---
>>   1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
>> index 7f8ff39..4bbfd8a 100644
>> --- a/drivers/hid/uhid.c
>> +++ b/drivers/hid/uhid.c
>> @@ -448,11 +448,20 @@ static int uhid_event_from_user(const char __user *buffer, size_t len,
>>                          kfree(compat);
>>                          return 0;
>>                  }
>> +
>>                  /* All others can be copied directly */
>> -       }
>> +               if (copy_from_user(event, buffer, min(len, sizeof(*event))))
>> +                       return -EFAULT;
>>
>> -       if (copy_from_user(event, buffer, min(len, sizeof(*event))))
>> -               return -EFAULT;
>> +               /*
>> +                * Override type in case the user process rushes to change it
>> +                * between two fetches
>> +                * */
>> +               event->type = type;
> So if we started with UHID_INPUT, userspace replaced it with
> UHID_FEATURE, we clobber the type UHID_INPUT leaving the rest of the
> structure holding the new data and call it a day? That does not make
> any sense to me.
I am not a maintainer so I am not in a position to judge which
function should do the input validation. But to me, given how
uhid_char_write() and uhid_event_from_user() are structured,
If we started with UHID_INPUT and later userspace replaced
it with UHID_FEATURE, it should be validated by uhid_dev_input.

If this patch, i.e., overriding event->type = type, is not
satisfactory to you, how about we change it to a sanity check?
Like if (event->type != type) return -EFAULT

By doing so, we make sure that if there is another thread
"scrambling" the memory, we simply do not proceed.
>
>> +       } else {
>> +               if (copy_from_user(event, buffer, min(len, sizeof(*event))))
>> +                       return -EFAULT;
>> +       }
>>
>>          return 0;
>>   }
>> --
>> 2.7.4
>>
> Thanks.
>

Re: [PATCH] hid/uhid: fix a double-fetch bug when copying event from user

[Dmitry Torokhov]

On Tue, Sep 19, 2017 at 2:54 PM, Meng Xu <meng.xu@gatech.edu> wrote:
>
>
> On 09/19/2017 05:31 PM, Dmitry Torokhov wrote:
>>
>> On Mon, Sep 18, 2017 at 10:21 PM, Meng Xu <mengxu.gatech@gmail.com> wrote:
>>>
>>> When in_compat_syscall(), a user could make type != UHID_CREATE when
>>> get_user(type, buffer) [first fetch] and later make event->type ==
>>> UHID_CREATE in copy_from_user(event, buffer, ...) [second fetch].
>>>
>>> By doing so, an attacker might circumvent the specific logic to handle
>>> the type == UHID_CREATE case and later cause undefined behaviors.
>>>
>>> This patch enforces that event->type is overriden to the type value
>>> copied in the first fetch and thus, mitigate this race condition attack.
>>
>> I do not believe this mitigates anything, as copy_form_user() is not
>> an atomic operation and we can have 2nd thread "scrambling" the memory
>> while 1st does the ioctl.
>
> Yes, what you described is the root cause of this double-fetch situation
> and that is why I am proposing this patch.
>>
>>
>> We also should not expect that we always get consistent data from
>> userspace and the rest of the driver should be able to cope with
>> (reject) such data.
>
> Yes, that is also true and we should never assume to get consistent
> data from userspace. That is why in this case, we can have user
> started with UHID_INPUT just to skip the large chunk of code in
> if (type == UHID_CREATE) {} and then replace it with UHID_CREATE
> and take the function uhid_dev_create(uhid, &uhid->input_buf).
> This is exactly what this patch tries to mitigate.

OK, so the driver should be able to withstand equivalent of "dd
if=/dev/random of=/dev/uhid". The point of special handling of
UHID_CREATE in uhid_event_from_user() is to convert the layout of the
UHID event from 32 to 64 bit layout because we made a mistake and have
a pointer data there. We do not really care about contents. We do not
care it if changes. We do not care of the pointer is valid. If there
was garbage, or there will be garbage after conversion, it does not
care one bit. uhid_dev_create() has to validate the input and reject
invalid input.

>
>>> Signed-off-by: Meng Xu <mengxu.gatech@gmail.com>
>>> ---
>>>   drivers/hid/uhid.c | 15 ++++++++++++---
>>>   1 file changed, 12 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
>>> index 7f8ff39..4bbfd8a 100644
>>> --- a/drivers/hid/uhid.c
>>> +++ b/drivers/hid/uhid.c
>>> @@ -448,11 +448,20 @@ static int uhid_event_from_user(const char __user
>>> *buffer, size_t len,
>>>                          kfree(compat);
>>>                          return 0;
>>>                  }
>>> +
>>>                  /* All others can be copied directly */
>>> -       }
>>> +               if (copy_from_user(event, buffer, min(len,
>>> sizeof(*event))))
>>> +                       return -EFAULT;
>>>
>>> -       if (copy_from_user(event, buffer, min(len, sizeof(*event))))
>>> -               return -EFAULT;
>>> +               /*
>>> +                * Override type in case the user process rushes to
>>> change it
>>> +                * between two fetches
>>> +                * */
>>> +               event->type = type;
>>
>> So if we started with UHID_INPUT, userspace replaced it with
>> UHID_FEATURE, we clobber the type UHID_INPUT leaving the rest of the
>> structure holding the new data and call it a day? That does not make
>> any sense to me.
>
> I am not a maintainer so I am not in a position to judge which
> function should do the input validation. But to me, given how
> uhid_char_write() and uhid_event_from_user() are structured,
> If we started with UHID_INPUT and later userspace replaced
> it with UHID_FEATURE, it should be validated by uhid_dev_input.
>
> If this patch, i.e., overriding event->type = type, is not
> satisfactory to you, how about we change it to a sanity check?
> Like if (event->type != type) return -EFAULT
>
> By doing so, we make sure that if there is another thread
> "scrambling" the memory, we simply do not proceed.

I do not think this is needed. If the scrambling results in invalid
request it should be rejected. If it results in valid request, it
should be accepted. That's it.

Thanks.

-- 
Dmitry

Re: [PATCH] hid/uhid: fix a double-fetch bug when copying event from user

[David Herrmann]

Hey

On Wed, Sep 20, 2017 at 12:12 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Tue, Sep 19, 2017 at 2:54 PM, Meng Xu <meng.xu@gatech.edu> wrote:
>>
>>
>> On 09/19/2017 05:31 PM, Dmitry Torokhov wrote:
>>>
>>> On Mon, Sep 18, 2017 at 10:21 PM, Meng Xu <mengxu.gatech@gmail.com> wrote:
>>>>
>>>> When in_compat_syscall(), a user could make type != UHID_CREATE when
>>>> get_user(type, buffer) [first fetch] and later make event->type ==
>>>> UHID_CREATE in copy_from_user(event, buffer, ...) [second fetch].
>>>>
>>>> By doing so, an attacker might circumvent the specific logic to handle
>>>> the type == UHID_CREATE case and later cause undefined behaviors.
>>>>
>>>> This patch enforces that event->type is overriden to the type value
>>>> copied in the first fetch and thus, mitigate this race condition attack.
>>>
>>> I do not believe this mitigates anything, as copy_form_user() is not
>>> an atomic operation and we can have 2nd thread "scrambling" the memory
>>> while 1st does the ioctl.
>>
>> Yes, what you described is the root cause of this double-fetch situation
>> and that is why I am proposing this patch.
>>>
>>>
>>> We also should not expect that we always get consistent data from
>>> userspace and the rest of the driver should be able to cope with
>>> (reject) such data.
>>
>> Yes, that is also true and we should never assume to get consistent
>> data from userspace. That is why in this case, we can have user
>> started with UHID_INPUT just to skip the large chunk of code in
>> if (type == UHID_CREATE) {} and then replace it with UHID_CREATE
>> and take the function uhid_dev_create(uhid, &uhid->input_buf).
>> This is exactly what this patch tries to mitigate.
>
> OK, so the driver should be able to withstand equivalent of "dd
> if=/dev/random of=/dev/uhid". The point of special handling of
> UHID_CREATE in uhid_event_from_user() is to convert the layout of the
> UHID event from 32 to 64 bit layout because we made a mistake and have
> a pointer data there. We do not really care about contents. We do not
> care it if changes. We do not care of the pointer is valid. If there
> was garbage, or there will be garbage after conversion, it does not
> care one bit. uhid_dev_create() has to validate the input and reject
> invalid input.

I agree.

With current code, worst case scenario is someone shortcutting the
compat-conversion by setting UHID_CREATE after uhid_event_from_user()
copied it. However, this does no harm, as Dmitry explained. If
user-space wants to shortcut the conversion, let them do so...

Thanks
David