From: Romain Gantois <romain.gantois@bootlin.com>
To: wsa+renesas@sang-engineering.com,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] misc: ti_fpc202: Switch to of_fwnode_handle()
Date: Mon, 12 May 2025 11:09:17 +0200 [thread overview]
Message-ID: <47222064.fMDQidcC6G@fw-rgant> (raw)
In-Reply-To: <20250512085852.2432422-1-jirislaby@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]
Hello Jiri,
On Monday, 12 May 2025 10:58:52 CEST Jiri Slaby (SUSE) wrote:
> of_node_to_fwnode() is an irqdomain's reimplementation of the
> "officially" defined of_fwnode_handle(). The former is in the process of
> being removed, so use the latter instead.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
> Cc: Romain Gantois <romain.gantois@bootlin.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/misc/ti_fpc202.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
> index b9c9ee4bfc4e..cc597682b89c 100644
> --- a/drivers/misc/ti_fpc202.c
> +++ b/drivers/misc/ti_fpc202.c
> @@ -284,7 +284,7 @@ static int fpc202_probe_port(struct fpc202_priv *priv,
> struct device_node *i2c_h
>
> desc.chan_id = port_id;
> desc.parent = dev;
> - desc.bus_handle = of_node_to_fwnode(i2c_handle);
> + desc.bus_handle = of_fwnode_handle(i2c_handle);
> desc.num_aliases = FPC202_ALIASES_PER_PORT;
>
> fpc202_fill_alias_table(priv->client, aliases, port_id);
Looks good to me.
Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-05-12 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 8:58 Jiri Slaby (SUSE)
2025-05-12 9:09 ` Romain Gantois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47222064.fMDQidcC6G@fw-rgant \
--to=romain.gantois@bootlin.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®