mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] misc: ti_fpc202: Switch to of_fwnode_handle()
@ 2025-05-12  8:58 Jiri Slaby (SUSE)
  2025-05-12  9:09 ` Romain Gantois
  0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby (SUSE) @ 2025-05-12  8:58 UTC (permalink / raw)
  To: wsa+renesas
  Cc: linux-kernel, Jiri Slaby (SUSE),
	Romain Gantois, Arnd Bergmann, Greg Kroah-Hartman

of_node_to_fwnode() is an irqdomain's reimplementation of the
"officially" defined of_fwnode_handle(). The former is in the process of
being removed, so use the latter instead.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
Cc: Romain Gantois <romain.gantois@bootlin.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/misc/ti_fpc202.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
index b9c9ee4bfc4e..cc597682b89c 100644
--- a/drivers/misc/ti_fpc202.c
+++ b/drivers/misc/ti_fpc202.c
@@ -284,7 +284,7 @@ static int fpc202_probe_port(struct fpc202_priv *priv, struct device_node *i2c_h
 
 	desc.chan_id = port_id;
 	desc.parent = dev;
-	desc.bus_handle = of_node_to_fwnode(i2c_handle);
+	desc.bus_handle = of_fwnode_handle(i2c_handle);
 	desc.num_aliases = FPC202_ALIASES_PER_PORT;
 
 	fpc202_fill_alias_table(priv->client, aliases, port_id);
-- 
2.49.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] misc: ti_fpc202: Switch to of_fwnode_handle()
  2025-05-12  8:58 [PATCH] misc: ti_fpc202: Switch to of_fwnode_handle() Jiri Slaby (SUSE)
@ 2025-05-12  9:09 ` Romain Gantois
  0 siblings, 0 replies; 2+ messages in thread
From: Romain Gantois @ 2025-05-12  9:09 UTC (permalink / raw)
  To: wsa+renesas, Jiri Slaby (SUSE)
  Cc: linux-kernel, Jiri Slaby (SUSE), Arnd Bergmann, Greg Kroah-Hartman

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

Hello Jiri,

On Monday, 12 May 2025 10:58:52 CEST Jiri Slaby (SUSE) wrote:
> of_node_to_fwnode() is an irqdomain's reimplementation of the
> "officially" defined of_fwnode_handle(). The former is in the process of
> being removed, so use the latter instead.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
> Cc: Romain Gantois <romain.gantois@bootlin.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/misc/ti_fpc202.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
> index b9c9ee4bfc4e..cc597682b89c 100644
> --- a/drivers/misc/ti_fpc202.c
> +++ b/drivers/misc/ti_fpc202.c
> @@ -284,7 +284,7 @@ static int fpc202_probe_port(struct fpc202_priv *priv,
> struct device_node *i2c_h
> 
>  	desc.chan_id = port_id;
>  	desc.parent = dev;
> -	desc.bus_handle = of_node_to_fwnode(i2c_handle);
> +	desc.bus_handle = of_fwnode_handle(i2c_handle);
>  	desc.num_aliases = FPC202_ALIASES_PER_PORT;
> 
>  	fpc202_fill_alias_table(priv->client, aliases, port_id);

Looks good to me.

Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-05-12  9:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-12  8:58 [PATCH] misc: ti_fpc202: Switch to of_fwnode_handle() Jiri Slaby (SUSE)
2025-05-12  9:09 ` Romain Gantois

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®