From: Matthias Brugger <matthias.bgg@gmail.com>
To: Sean Wang <sean.wang@mediatek.com>
Cc: chenglin.xu@mediatek.com, chen.zhong@mediatek.com,
arvind.yadav.cs@gmail.com, christophe.jaillet@wanadoo.fr,
robh@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error
Date: Sun, 22 Oct 2017 12:02:15 +0200 [thread overview]
Message-ID: <4722c8ca-b967-7f35-8c8c-f718f40612a2@gmail.com> (raw)
In-Reply-To: <1508646191.29850.23.camel@mtkswgap22>
On 10/22/2017 06:23 AM, Sean Wang wrote:
> On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote:
>> When adding the MT6380 compatible, the sentinel for of_device_id was
>> deleted, which leades to the following compiler error:
>> FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry!
>>
>> Fix this by adding the sentinel again.
>>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>> ---
>> drivers/soc/mediatek/mtk-pmic-wrap.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> index 912edf93c192..e9e054a15b7d 100644
>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = {
>> }, {
>> .compatible = "mediatek,mt6397",
>> .data = &pmic_mt6397,
>> + }, {
>> /* sentinel */
>> }
>> };
>
> Thanks for patching the mistaken edit I made.
>
> Acked-by: Sean Wang <sean.wang@mediatek.com>
>
>
Thanks, both patches pushed to v4.14-next/soc
prev parent reply other threads:[~2017-10-22 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-21 8:25 [PATCH 1/2] soc: mediatek: pwrap: fix compiler errors Matthias Brugger
2017-10-21 8:25 ` [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error Matthias Brugger
2017-10-22 4:23 ` Sean Wang
2017-10-22 10:02 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4722c8ca-b967-7f35-8c8c-f718f40612a2@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=chen.zhong@mediatek.com \
--cc=chenglin.xu@mediatek.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®