[PATCH] PERCPU : __percpu_alloc_mask() can dynamically size percpu_data storage

[PATCH] PERCPU : __percpu_alloc_mask() can dynamically size percpu_data storage

[Eric Dumazet]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Instead of allocating a fix sized array of NR_CPUS pointers for percpu_data, 
we can use nr_cpu_ids, which is generally < NR_CPUS.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

  include/linux/percpu.h |    2 +-
  mm/allocpercpu.c       |    2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)


[-- Attachment #2: percpu_data.patch --]
[-- Type: text/plain, Size: 785 bytes --]

diff --git a/include/linux/percpu.h b/include/linux/percpu.h
index 926adaa..1702ab5 100644
--- a/include/linux/percpu.h
+++ b/include/linux/percpu.h
@@ -34,7 +34,7 @@
 #ifdef CONFIG_SMP
 
 struct percpu_data {
-	void *ptrs[NR_CPUS];
+	void *ptrs[1];
 };
 
 #define __percpu_disguise(pdata) (struct percpu_data *)~(unsigned long)(pdata)
diff --git a/mm/allocpercpu.c b/mm/allocpercpu.c
index 00b0262..7e58322 100644
--- a/mm/allocpercpu.c
+++ b/mm/allocpercpu.c
@@ -98,7 +98,7 @@ EXPORT_SYMBOL_GPL(__percpu_populate_mask);
  */
 void *__percpu_alloc_mask(size_t size, gfp_t gfp, cpumask_t *mask)
 {
-	void *pdata = kzalloc(sizeof(struct percpu_data), gfp);
+	void *pdata = kzalloc(nr_cpu_ids * sizeof(void *), gfp);
 	void *__pdata = __percpu_disguise(pdata);
 
 	if (unlikely(!pdata))

Re: [PATCH] PERCPU : __percpu_alloc_mask() can dynamically size percpu_data storage

[Christoph Lameter]

On Fri, 16 Nov 2007, Eric Dumazet wrote:

> Instead of allocating a fix sized array of NR_CPUS pointers for percpu_data,
> we can use nr_cpu_ids, which is generally < NR_CPUS.

Yes we can. Could you either use [] or [0] instead of the index there? 
Somehow the patch vanished when I replied to it.