mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: Zi Yan <ziy@nvidia.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	"Liam R. Howlett" <liam@infradead.org>,
	Nico Pache <nico.pache@linux.dev>,
	Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
	Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
	Usama Arif <usama.arif@linux.dev>, Peter Xu <peterx@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Cedric Le Goater <clg@redhat.com>,
	Saravanan D <saravanand@crusoe.ai>,
	stable@vger.kernel.org
Subject: Re: [PATCH] mm/huge_memory: bypass THP tuneables for huge pfnmap mappings
Date: Mon, 7 Sep 2026 18:19:30 +0200	[thread overview]
Message-ID: <4743f22a-c24f-4f93-80f5-3260f29bd410@kernel.org> (raw)
In-Reply-To: <ap7i1vLkfZj4rbNM@gremlin>

On 9/7/26 18:15, Lorenzo Stoakes (ARM) wrote:
> On Mon, Sep 07, 2026 at 06:08:31PM +0200, David Hildenbrand (Arm) wrote:
>>
>>>
>>> That's a good idea! Much better thanks.
>>>
>>>
>>> Yeah, it's an annoying one as kinda want to say 'file-backed VMA' but I think
>>> you're right vma_xxx_file() -> vma_file_xxx() is better.
>>>
>>> Andrew - could you fix that up in place?
>>>
>>> Obviously if there's further feedback I can respin as well.
>>
>> Just as a general note I really hate these in-place updates.
>>
>> For a reviewer perspective (like me stumbling over this) this is just a mess.
>>
>> Resending with b4 is as easy as it gets.
> 
> Ack, you are right to be honest, and I do empathise obviously.
> 
> I will respin these in future!
> 
> Let me know if you want me to respin this to make life a bit easier?

Sorry for being grumpy. With 1500 unread mails, playing Hensel and searching for
breadcrumbs in my inbox is hard :D

(I did see some reply from Zi to an mm-unstable patch, but not sure if that was
applied in the end -- or whether Andrew fixed up any of that)

I just saw my reply to my other mail, maybe a v2 would be best :)

-- 
Cheers,

David

  reply	other threads:[~2026-09-07 16:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 19:55 Lorenzo Stoakes (ARM)
2026-08-28  2:52 ` Zi Yan
2026-08-28  7:11   ` Lorenzo Stoakes (ARM)
2026-09-07 16:08     ` David Hildenbrand (Arm)
2026-09-07 16:15       ` Lorenzo Stoakes (ARM)
2026-09-07 16:19         ` David Hildenbrand (Arm) [this message]
2026-09-07 16:30           ` Lorenzo Stoakes (ARM)
2026-09-07 16:58             ` Zi Yan
2026-09-07 17:00               ` David Hildenbrand (Arm)
2026-09-07 17:05                 ` Zi Yan
2026-08-28  4:47 ` Lance Yang
2026-08-28 16:46 ` Saravanan D
2026-08-28 17:20   ` Lorenzo Stoakes (ARM)
2026-08-29  0:24 ` SJ Park
2026-08-31  8:15 ` Baolin Wang
2026-09-07 16:14 ` David Hildenbrand (Arm)
2026-09-07 16:17   ` Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4743f22a-c24f-4f93-80f5-3260f29bd410@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=clg@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=jgg@ziepe.ca \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=nico.pache@linux.dev \
    --cc=peterx@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=saravanand@crusoe.ai \
    --cc=stable@vger.kernel.org \
    --cc=usama.arif@linux.dev \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®