From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>, Zi Yan <ziy@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <liam@infradead.org>,
Nico Pache <nico.pache@linux.dev>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Usama Arif <usama.arif@linux.dev>, Peter Xu <peterx@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Cedric Le Goater <clg@redhat.com>,
Saravanan D <saravanand@crusoe.ai>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/huge_memory: bypass THP tuneables for huge pfnmap mappings
Date: Mon, 7 Sep 2026 18:08:31 +0200 [thread overview]
Message-ID: <dc52dd1d-f62d-4278-ab4d-95746383fd50@kernel.org> (raw)
In-Reply-To: <apEzvfGgsvbc3vBI@gremlin>
>> 1. is vma_allow_thp_tuneables_file() better? Then all three helpers are
>> vma + a verb + thp_tuneables_file().
>
> That's a good idea! Much better thanks.
>
>>
>> 2. is vma_file_ a better prefix than putting file at the end?
>
> Yeah, it's an annoying one as kinda want to say 'file-backed VMA' but I think
> you're right vma_xxx_file() -> vma_file_xxx() is better.
>
> Andrew - could you fix that up in place?
>
> Obviously if there's further feedback I can respin as well.
Just as a general note I really hate these in-place updates.
For a reviewer perspective (like me stumbling over this) this is just a mess.
Resending with b4 is as easy as it gets.
--
Cheers,
David
next prev parent reply other threads:[~2026-09-07 16:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 19:55 Lorenzo Stoakes (ARM)
2026-08-28 2:52 ` Zi Yan
2026-08-28 7:11 ` Lorenzo Stoakes (ARM)
2026-09-07 16:08 ` David Hildenbrand (Arm) [this message]
2026-09-07 16:15 ` Lorenzo Stoakes (ARM)
2026-09-07 16:19 ` David Hildenbrand (Arm)
2026-09-07 16:30 ` Lorenzo Stoakes (ARM)
2026-09-07 16:58 ` Zi Yan
2026-09-07 17:00 ` David Hildenbrand (Arm)
2026-09-07 17:05 ` Zi Yan
2026-08-28 4:47 ` Lance Yang
2026-08-28 16:46 ` Saravanan D
2026-08-28 17:20 ` Lorenzo Stoakes (ARM)
2026-08-29 0:24 ` SJ Park
2026-08-31 8:15 ` Baolin Wang
2026-09-07 16:14 ` David Hildenbrand (Arm)
2026-09-07 16:17 ` Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc52dd1d-f62d-4278-ab4d-95746383fd50@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=clg@redhat.com \
--cc=dev.jain@arm.com \
--cc=jgg@ziepe.ca \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=nico.pache@linux.dev \
--cc=peterx@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=saravanand@crusoe.ai \
--cc=stable@vger.kernel.org \
--cc=usama.arif@linux.dev \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®