mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* __get_vm_area() with VM_IOREMAP
@ 2007-12-13 16:56 Jan Beulich
  0 siblings, 0 replies; only message in thread
From: Jan Beulich @ 2007-12-13 16:56 UTC (permalink / raw)
  To: James.Bottomley; +Cc: linux-kernel

James,

in a change over three years ago, you added implicit aligning to
__get_vm_area() for VM_IOREMAP requests. I wonder, though,
whether it was intentional to over-align requests of sizes that are
an exact power of two (and between PAGE_SIZE and
(1 << IOREMAP_MAX_ORDER)). I would think that the argument of
fls() should be (size - 1) rather than size.

Thanks, Jan


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-12-13 16:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-13 16:56 __get_vm_area() with VM_IOREMAP Jan Beulich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®