mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Roberts, William C" <william.c.roberts@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	"Tobin C. Harding" <me@tobin.cc>
Cc: "kernel-hardening@lists.openwall.com" 
	<kernel-hardening@lists.openwall.com>,
	KVM list <kvm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Tycho Andersen <tycho@docker.com>, Tejun Heo <tj@kernel.org>,
	Jordan Glover <Golden_Miller83@protonmail.ch>,
	Greg KH <gregkh@linuxfoundation.org>,
	"Petr Mladek" <pmladek@suse.com>, Joe Perches <joe@perches.com>,
	Ian Campbell <ijc@hellion.org.uk>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Chris Fries <cfries@google.com>,
	"Dave Weinstein" <olorin@google.com>,
	Daniel Micay <danielmicay@gmail.com>,
	Djalal Harouni <tixxdz@gmail.com>
Subject: RE: [PATCH 0/3] add %pX specifier
Date: Fri, 13 Oct 2017 17:54:17 +0000	[thread overview]
Message-ID: <476DC76E7D1DF2438D32BFADF679FC563F4AF591@ORSMSX115.amr.corp.intel.com> (raw)
In-Reply-To: <CA+55aFyH5X2nx0kf_hPeOjMQYF-UX6r3ov61=VqTOLLZLE3-vQ@mail.gmail.com>



> -----Original Message-----
> From: linus971@gmail.com [mailto:linus971@gmail.com] On Behalf Of Linus
> Torvalds
> Sent: Tuesday, October 10, 2017 4:17 PM
> To: Tobin C. Harding <me@tobin.cc>
> Cc: kernel-hardening@lists.openwall.com; KVM list <kvm@vger.kernel.org>;
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Kees Cook
> <keescook@chromium.org>; Paolo Bonzini <pbonzini@redhat.com>; Tycho
> Andersen <tycho@docker.com>; Roberts, William C
> <william.c.roberts@intel.com>; Tejun Heo <tj@kernel.org>; Jordan Glover
> <Golden_Miller83@protonmail.ch>; Greg KH <gregkh@linuxfoundation.org>;
> Petr Mladek <pmladek@suse.com>; Joe Perches <joe@perches.com>; Ian
> Campbell <ijc@hellion.org.uk>; Sergey Senozhatsky
> <sergey.senozhatsky@gmail.com>; Catalin Marinas <catalin.marinas@arm.com>;
> Will Deacon <will.deacon@arm.com>; Steven Rostedt <rostedt@goodmis.org>;
> Chris Fries <cfries@google.com>; Dave Weinstein <olorin@google.com>; Daniel
> Micay <danielmicay@gmail.com>; Djalal Harouni <tixxdz@gmail.com>
> Subject: Re: [PATCH 0/3] add %pX specifier
> 
> On Tue, Oct 10, 2017 at 4:09 PM, Tobin C. Harding <me@tobin.cc> wrote:
> >
> > This patch is a softer version of Linus' suggestion because it does
> > not change the behaviour of the %p specifier. I don't see the benefit
> > in making such a breaking change without addressing the issue of %x (and I
> don't the balls to right now).
> 
> The thing is, this continues to have the exact same issue that %pK has
> - because it is opt-in, effectively nobody will actually use it.
> 
> That's why I would suggest that if we do this way, we really change %p and %pa
> to use the hashed value, to convert *everybody*. And then people who have a
> good reason to actually expose the pointer have to do the extra work and opt
> out.

Yes we cannot make this opt in or there is really no point in doing it. %pK and mistakes
got us here to this point. I see there is multiple threads, this getting really fun to follow.

> 
>                   Linus

  parent reply	other threads:[~2017-10-13 17:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 23:09 Tobin C. Harding
2017-10-10 23:15 ` Linus Torvalds
2017-10-10 23:32   ` Tobin C. Harding
2017-10-11  3:27     ` Joe Perches
2017-10-11 20:11   ` Jason A. Donenfeld
2017-10-11 21:29     ` Linus Torvalds
2017-10-11 22:11       ` Jason A. Donenfeld
2017-10-12 18:37         ` Linus Torvalds
2017-10-10 23:16 ` Linus Torvalds
2017-10-10 23:31   ` Tobin C. Harding
2017-10-13 17:54   ` Roberts, William C [this message]
2017-10-16  2:09     ` Tobin Harding
2017-10-11 20:09 ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=476DC76E7D1DF2438D32BFADF679FC563F4AF591@ORSMSX115.amr.corp.intel.com \
    --to=william.c.roberts@intel.com \
    --cc=Golden_Miller83@protonmail.ch \
    --cc=catalin.marinas@arm.com \
    --cc=cfries@google.com \
    --cc=danielmicay@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc@hellion.org.uk \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@tobin.cc \
    --cc=olorin@google.com \
    --cc=pbonzini@redhat.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tixxdz@gmail.com \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tycho@docker.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®