From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: kernel-hardening@lists.openwall.com, kvm@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Tycho Andersen <tycho@docker.com>,
"Roberts, William C" <william.c.roberts@intel.com>,
Tejun Heo <tj@kernel.org>,
Jordan Glover <Golden_Miller83@protonmail.ch>,
Greg KH <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
Ian Campbell <ijc@hellion.org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Chris Fries <cfries@google.com>,
Dave Weinstein <olorin@google.com>,
Daniel Micay <danielmicay@gmail.com>,
Djalal Harouni <tixxdz@gmail.com>
Subject: Re: [PATCH 0/3] add %pX specifier
Date: Wed, 11 Oct 2017 22:09:20 +0200 [thread overview]
Message-ID: <CAHmME9qPguYLUk-CsKB7LEsTiP6spha-Rt7r41KG=TMdj3FnHw@mail.gmail.com> (raw)
In-Reply-To: <1507676974-1298-1-git-send-email-me@tobin.cc>
Hi Tobin,
On Wed, Oct 11, 2017 at 1:09 AM, Tobin C. Harding <me@tobin.cc> wrote:
>
> + hashval = hash_three_words(
> + (unsigned long)ptr,
> + (unsigned long)ptr >> 16 >> 16,
> + boot_time_random_int);
This is most likely not what you want to be using. Take a look at the
siphash_* set of functions. If you're just hashing 1 64-bit pointer
with some secret, use siphash_1u64, for example. That's the right
interface for this purpose.
Regards,
Jason
prev parent reply other threads:[~2017-10-11 20:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 23:09 Tobin C. Harding
2017-10-10 23:15 ` Linus Torvalds
2017-10-10 23:32 ` Tobin C. Harding
2017-10-11 3:27 ` Joe Perches
2017-10-11 20:11 ` Jason A. Donenfeld
2017-10-11 21:29 ` Linus Torvalds
2017-10-11 22:11 ` Jason A. Donenfeld
2017-10-12 18:37 ` Linus Torvalds
2017-10-10 23:16 ` Linus Torvalds
2017-10-10 23:31 ` Tobin C. Harding
2017-10-13 17:54 ` Roberts, William C
2017-10-16 2:09 ` Tobin Harding
2017-10-11 20:09 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9qPguYLUk-CsKB7LEsTiP6spha-Rt7r41KG=TMdj3FnHw@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=Golden_Miller83@protonmail.ch \
--cc=catalin.marinas@arm.com \
--cc=cfries@google.com \
--cc=danielmicay@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc@hellion.org.uk \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=olorin@google.com \
--cc=pbonzini@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tixxdz@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@docker.com \
--cc=will.deacon@arm.com \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®