mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: imx-audmux: Convert to subsys_platform_driver()
@ 2026-11-04 11:32 Peng Fan (OSS)
  2026-11-04 12:19 ` Daniel Baluta
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Peng Fan (OSS) @ 2026-11-04 11:32 UTC (permalink / raw)
  To: Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen,
	Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team
  Cc: linux-sound, linuxppc-dev, imx, linux-arm-kernel, linux-kernel

From: Peng Fan <peng.fan@nxp.com>

Replace the open-coded subsys_initcall()/module_exit() platform driver
registration with subsys_platform_driver().

No functional change.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 sound/soc/fsl/imx-audmux.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
index f8335a04595a..d46f43ab66cf 100644
--- a/sound/soc/fsl/imx-audmux.c
+++ b/sound/soc/fsl/imx-audmux.c
@@ -361,18 +361,7 @@ static struct platform_driver imx_audmux_driver = {
 		.of_match_table = imx_audmux_dt_ids,
 	}
 };
-
-static int __init imx_audmux_init(void)
-{
-	return platform_driver_register(&imx_audmux_driver);
-}
-subsys_initcall(imx_audmux_init);
-
-static void __exit imx_audmux_exit(void)
-{
-	platform_driver_unregister(&imx_audmux_driver);
-}
-module_exit(imx_audmux_exit);
+subsys_platform_driver(imx_audmux_driver);
 
 MODULE_DESCRIPTION("Freescale i.MX AUDMUX driver");
 MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>");
-- 
2.51.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: imx-audmux: Convert to subsys_platform_driver()
  2026-11-04 11:32 [PATCH] ASoC: imx-audmux: Convert to subsys_platform_driver() Peng Fan (OSS)
@ 2026-11-04 12:19 ` Daniel Baluta
  2026-11-05  1:07 ` Mark Brown
  2026-11-05  2:52 ` Shengjiu Wang
  2 siblings, 0 replies; 4+ messages in thread
From: Daniel Baluta @ 2026-11-04 12:19 UTC (permalink / raw)
  To: Peng Fan (OSS),
	Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen,
	Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team
  Cc: linux-sound, linuxppc-dev, imx, linux-arm-kernel, linux-kernel

On 11/4/26 13:32, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Replace the open-coded subsys_initcall()/module_exit() platform driver
> registration with subsys_platform_driver().
> 
> No functional change.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

sashiko comment doesn't seem to be correct. > ---
>  sound/soc/fsl/imx-audmux.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
> index f8335a04595a..d46f43ab66cf 100644
> --- a/sound/soc/fsl/imx-audmux.c
> +++ b/sound/soc/fsl/imx-audmux.c
> @@ -361,18 +361,7 @@ static struct platform_driver imx_audmux_driver = {
>  		.of_match_table = imx_audmux_dt_ids,
>  	}
>  };
> -
> -static int __init imx_audmux_init(void)
> -{
> -	return platform_driver_register(&imx_audmux_driver);
> -}
> -subsys_initcall(imx_audmux_init);
> -
> -static void __exit imx_audmux_exit(void)
> -{
> -	platform_driver_unregister(&imx_audmux_driver);
> -}
> -module_exit(imx_audmux_exit);
> +subsys_platform_driver(imx_audmux_driver);
>  
>  MODULE_DESCRIPTION("Freescale i.MX AUDMUX driver");
>  MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>");


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: imx-audmux: Convert to subsys_platform_driver()
  2026-11-04 11:32 [PATCH] ASoC: imx-audmux: Convert to subsys_platform_driver() Peng Fan (OSS)
  2026-11-04 12:19 ` Daniel Baluta
@ 2026-11-05  1:07 ` Mark Brown
  2026-11-05  2:52 ` Shengjiu Wang
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2026-11-05  1:07 UTC (permalink / raw)
  To: Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen,
	Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Peng Fan (OSS)
  Cc: linux-sound, linuxppc-dev, imx, linux-arm-kernel, linux-kernel

On Wed, 04 Nov 2026 19:32:28 +0800, Peng Fan (OSS) wrote:
> ASoC: imx-audmux: Convert to subsys_platform_driver()

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.5

Thanks!

[1/1] ASoC: imx-audmux: Convert to subsys_platform_driver()
      https://git.kernel.org/broonie/sound/c/aa56acd47629

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: imx-audmux: Convert to subsys_platform_driver()
  2026-11-04 11:32 [PATCH] ASoC: imx-audmux: Convert to subsys_platform_driver() Peng Fan (OSS)
  2026-11-04 12:19 ` Daniel Baluta
  2026-11-05  1:07 ` Mark Brown
@ 2026-11-05  2:52 ` Shengjiu Wang
  2 siblings, 0 replies; 4+ messages in thread
From: Shengjiu Wang @ 2026-11-05  2:52 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: Xiubo Li, Fabio Estevam, Nicolin Chen, Liam Girdwood, Mark Brown,
	Jaroslav Kysela, Takashi Iwai, Frank Li, Sascha Hauer,
	Pengutronix Kernel Team, linux-sound, linuxppc-dev, imx,
	linux-arm-kernel, linux-kernel

On Wed, Nov 4, 2026 at 7:35 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Replace the open-coded subsys_initcall()/module_exit() platform driver
> registration with subsys_platform_driver().
>
> No functional change.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Shengjiu Wang <shengjiu.wang@gmail.com>

Best regards
Shengjiu Wang
> ---
>  sound/soc/fsl/imx-audmux.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
> index f8335a04595a..d46f43ab66cf 100644
> --- a/sound/soc/fsl/imx-audmux.c
> +++ b/sound/soc/fsl/imx-audmux.c
> @@ -361,18 +361,7 @@ static struct platform_driver imx_audmux_driver = {
>                 .of_match_table = imx_audmux_dt_ids,
>         }
>  };
> -
> -static int __init imx_audmux_init(void)
> -{
> -       return platform_driver_register(&imx_audmux_driver);
> -}
> -subsys_initcall(imx_audmux_init);
> -
> -static void __exit imx_audmux_exit(void)
> -{
> -       platform_driver_unregister(&imx_audmux_driver);
> -}
> -module_exit(imx_audmux_exit);
> +subsys_platform_driver(imx_audmux_driver);
>
>  MODULE_DESCRIPTION("Freescale i.MX AUDMUX driver");
>  MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>");
> --
> 2.51.0
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-05 11:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-04 11:32 [PATCH] ASoC: imx-audmux: Convert to subsys_platform_driver() Peng Fan (OSS)
2026-11-04 12:19 ` Daniel Baluta
2026-11-05  1:07 ` Mark Brown
2026-11-05  2:52 ` Shengjiu Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®