mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, olof@lixom.net
Subject: Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()
Date: Fri, 04 Jan 2008 02:38:35 -0800	[thread overview]
Message-ID: <477E0CAB.2040402@linux.intel.com> (raw)
In-Reply-To: <20080104074523.GD17447@elte.hu>

Ingo Molnar wrote:
> * Arjan van de Ven <arjan@linux.intel.com> wrote:
> 
>> +	printk(KERN_WARNING "------------[ cut here ]------------\n");
>>  	printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file,
>>  		line, function);
>> +	print_modules();
>>  	dump_stack();
>> +	print_oops_end_marker();
> 
> another thing: could we also put the marker into dump_stack(), and 
> attach the marker to the Call Trace line?
> 

I have a preliminary patch for that already but I'm not happy with it yet;
I need to redo it properly. It's neither depending nor incremental to these
2 patches though..

  reply	other threads:[~2008-01-04 10:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03 21:27 Arjan van de Ven
2008-01-04  7:45 ` Ingo Molnar
2008-01-04 10:38   ` Arjan van de Ven [this message]
2008-01-04 10:43     ` Ingo Molnar
2008-01-04 10:48 ` Heiko Carstens
2008-01-04 14:50   ` Arjan van de Ven
2008-01-04 17:19     ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477E0CAB.2040402@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome