Re: [PATCH v5 3/5] dt-bindings: display/msm: Document MDSS on QCS8300

[Yongxing Mou <quic_yongmou@quicinc.com>]

On 2025/8/2 17:56, Dmitry Baryshkov wrote:
> On Wed, Jul 30, 2025 at 05:42:28PM +0800, Yongxing Mou wrote:
>> Document the MDSS hardware found on the Qualcomm QCS8300 platform.
>>
>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
>> ---
>>   .../bindings/display/msm/qcom,qcs8300-mdss.yaml    | 284 +++++++++++++++++++++
>>   1 file changed, 284 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..ae4bc16395326bffd6c9eff92778d9f207209526
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
>> @@ -0,0 +1,284 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/msm/qcom,qcs8300-mdss.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. QCS8300 Display MDSS
>> +
>> +maintainers:
>> +  - Yongxing Mou <quic_yongmou@quicinc.com>
>> +
>> +description:
>> +  QCS8300 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
>> +  DPU display controller, DP interfaces and EDP etc.
>> +
>> +$ref: /schemas/display/msm/mdss-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,qcs8300-mdss
>> +
>> +  clocks:
>> +    items:
>> +      - description: Display AHB
>> +      - description: Display hf AXI
>> +      - description: Display core
>> +
>> +  iommus:
>> +    maxItems: 1
>> +
>> +  interconnects:
>> +    maxItems: 3
>> +
>> +  interconnect-names:
>> +    maxItems: 3
>> +
>> +patternProperties:
>> +  "^display-controller@[0-9a-f]+$":
>> +    type: object
>> +    additionalProperties: true
>> +
>> +    properties:
>> +      compatible:
>> +        items:
>> +          - const: qcom,qcs8300-dpu
>> +          - const: qcom,sa8775p-dpu
> 
> Use contains: instead of listing both of them
> 
Got it, thanks~ here we want to fallback qcs8300 to sa8775p.
Should we update it to :
+        contains:
+          enum:
+            - qcom,qcs8300-dpu
+            - qcom,sa8775p-dpu

  above method can be validated using dt_binding_check.
>> +
>> +  "^displayport-controller@[0-9a-f]+$":
>> +    type: object
>> +    additionalProperties: true
>> +
>> +    properties:
>> +      compatible:
>> +        items:
>> +          - const: qcom,qcs8300-dp
>> +
>> +  "^phy@[0-9a-f]+$":
>> +    type: object
>> +    additionalProperties: true
>> +    properties:
>> +      compatible:
>> +        items:
>> +          - const: qcom,qcs8300-edp-phy
>> +          - const: qcom,sa8775p-edp-phy
> 
> Use contains: instead of listing both of them
> 
Same as above
>> +
>> +required:
>> +  - compatible
>> +
>> +unevaluatedProperties: false
>> +
>