Re: [PATCH v5 2/5] dt-bindings: display/msm: dp-controller: document QCS8300 compatible

[Yongxing Mou <quic_yongmou@quicinc.com>]

On 2025/7/31 2:04, Dmitry Baryshkov wrote:
> On Wed, Jul 30, 2025 at 05:42:27PM +0800, Yongxing Mou wrote:
>> Add compatible string for the DisplayPort controller found on the
>> Qualcomm QCS8300 SoC, which uses the same DPU as the SA8775P. While
>> DP0 supports 4 MST streams, DP1 has been removed at the silicon level,
>> so SA8775P/SM8650 cannot be used as fallback compatibles.
> 
> "It uses the same DPU as SA8775P, but we can not use SA8775P's DP
> compatible". There is some logic issue there. Please rewrite to speak
> only about DP.
> 
> Moreover, removing of DP1 should not affect DP0 being compatible or
> incompatible with other platforms.
> 
>>
>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>> index 2893f097df826a5f941fbb754fb4a96a1e410a70..f5930f29c91ec95e9182c7b8ee83c0549c6657cc 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>> @@ -18,6 +18,7 @@ properties:
>>     compatible:
>>       oneOf:
>>         - enum:
>> +          - qcom,qcs8300-dp
>>             - qcom,sa8775p-dp
>>             - qcom,sc7180-dp
>>             - qcom,sc7280-dp
>> @@ -186,6 +187,7 @@ allOf:
>>           compatible:
>>             contains:
>>               enum:
>> +              - qcom,qcs8300-dp
>>                 - qcom,sa8775p-dp
>>                 - qcom,sc7280-dp
>>                 - qcom,sc8180x-dp
>>
>> -- 
>> 2.34.1
>>
> 
Okay, will update it in next version. thanks~