* [PATCH 0/3] Regulator adjustments for OnePlus 6 and 6T
@ 2025-11-18 14:11 David Heidelberg via B4 Relay
2025-11-18 14:11 ` [PATCH 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on David Heidelberg via B4 Relay
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-11-18 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
David Heidelberg, Casey Connolly
Small regulators adjustments, tested on sdm845-mainline and sdm845-next
tree with recently fixed (6) and upstreamed (6T) drivers.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Casey Connolly (3):
arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on
arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on
arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
---
base-commit: 187dac290bfd0741b9d7d5490af825c33fd9baa4
change-id: 20251118-dts-oneplus-regulators-08aaa85fca38
Best regards,
--
David Heidelberg <david@ixit.cz>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on
2025-11-18 14:11 [PATCH 0/3] Regulator adjustments for OnePlus 6 and 6T David Heidelberg via B4 Relay
@ 2025-11-18 14:11 ` David Heidelberg via B4 Relay
2025-11-18 14:32 ` Konrad Dybcio
2025-11-18 14:11 ` [PATCH 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on David Heidelberg via B4 Relay
2025-11-18 14:11 ` [PATCH 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on David Heidelberg via B4 Relay
2 siblings, 1 reply; 9+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-11-18 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
David Heidelberg, Casey Connolly
From: Casey Connolly <casey.connolly@linaro.org>
The touchscreen 1.8v supply doesn't need to be enabled at boot, only
when the driver probes. Remove the regulator-boot-on property.
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index db6dd04c51bb5..ee62adfa6af0b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -148,7 +148,6 @@ ts_1p8_supply: ts-1p8-regulator {
gpio = <&tlmm 88 0>;
enable-active-high;
- regulator-boot-on;
};
panel_vci_3v3: panel-vci-3v3-regulator {
--
2.51.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on
2025-11-18 14:11 [PATCH 0/3] Regulator adjustments for OnePlus 6 and 6T David Heidelberg via B4 Relay
2025-11-18 14:11 ` [PATCH 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on David Heidelberg via B4 Relay
@ 2025-11-18 14:11 ` David Heidelberg via B4 Relay
2025-11-18 14:32 ` Konrad Dybcio
2025-11-18 14:11 ` [PATCH 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on David Heidelberg via B4 Relay
2 siblings, 1 reply; 9+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-11-18 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
David Heidelberg, Casey Connolly
From: Casey Connolly <casey.connolly@linaro.org>
The panel regulator doesn't need to be always on, so remove this
property.
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index ee62adfa6af0b..5845bc3bb80b2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -272,7 +272,6 @@ vreg_l14a_1p88: ldo14 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- regulator-always-on;
};
vreg_l17a_1p3: ldo17 {
--
2.51.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on
2025-11-18 14:11 [PATCH 0/3] Regulator adjustments for OnePlus 6 and 6T David Heidelberg via B4 Relay
2025-11-18 14:11 ` [PATCH 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on David Heidelberg via B4 Relay
2025-11-18 14:11 ` [PATCH 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on David Heidelberg via B4 Relay
@ 2025-11-18 14:11 ` David Heidelberg via B4 Relay
2025-11-18 14:32 ` Konrad Dybcio
2 siblings, 1 reply; 9+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-11-18 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
David Heidelberg, Casey Connolly
From: Casey Connolly <casey.connolly@linaro.org>
This regulator is used only for the display, which is enabled by the
bootloader and left on for continuous splash. Mark it as such.
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index 5845bc3bb80b2..8251f5a2f9475 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -272,6 +272,7 @@ vreg_l14a_1p88: ldo14 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-boot-on;
};
vreg_l17a_1p3: ldo17 {
--
2.51.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on
2025-11-18 14:11 ` [PATCH 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on David Heidelberg via B4 Relay
@ 2025-11-18 14:32 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2025-11-18 14:32 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, Casey Connolly
On 11/18/25 3:11 PM, David Heidelberg via B4 Relay wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
>
> The touchscreen 1.8v supply doesn't need to be enabled at boot, only
> when the driver probes. Remove the regulator-boot-on property.
This is not exactly what this property signifies (although it does
indeed turn the regulator on if it's not)
regulator-boot-on:
description: bootloader/firmware enabled regulator.
It's expected that this regulator was left on by the bootloader.
If the bootloader didn't leave it on then OS should turn it on
at boot but shouldn't prevent it from being turned off later.
This property is intended to only be used for regulators where
software cannot read the state of the regulator.
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on
2025-11-18 14:11 ` [PATCH 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on David Heidelberg via B4 Relay
@ 2025-11-18 14:32 ` Konrad Dybcio
2025-11-18 14:44 ` David Heidelberg
0 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2025-11-18 14:32 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, Casey Connolly
On 11/18/25 3:11 PM, David Heidelberg via B4 Relay wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
>
> The panel regulator doesn't need to be always on, so remove this
> property.
>
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
Fixes?
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on
2025-11-18 14:11 ` [PATCH 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on David Heidelberg via B4 Relay
@ 2025-11-18 14:32 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2025-11-18 14:32 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, Casey Connolly
On 11/18/25 3:11 PM, David Heidelberg via B4 Relay wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
>
> This regulator is used only for the display, which is enabled by the
> bootloader and left on for continuous splash. Mark it as such.
>
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
Fixes?
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on
2025-11-18 14:32 ` Konrad Dybcio
@ 2025-11-18 14:44 ` David Heidelberg
2025-11-18 14:49 ` Konrad Dybcio
0 siblings, 1 reply; 9+ messages in thread
From: David Heidelberg @ 2025-11-18 14:44 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, Casey Connolly
On 18/11/2025 15:32, Konrad Dybcio wrote:
> On 11/18/25 3:11 PM, David Heidelberg via B4 Relay wrote:
>> From: Casey Connolly <casey.connolly@linaro.org>
>>
>> The panel regulator doesn't need to be always on, so remove this
>> property.
>>
>> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>
> Fixes?
I only know this works well at current next-202511xx, these patches
we're also in sdm845-mainline downstream repo, but there was multiple
different patches and hacks for panels and other stuff present, so it's
hard for me verify that on clean mainline kernel these will work as
expected (as older mainline versions also need the panel patched etc.)
If you insist, I can append Fixes against when these properties we're or
weren't introduced (talking about PATCH 3/3 too).
>
> Konrad
--
David Heidelberg
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on
2025-11-18 14:44 ` David Heidelberg
@ 2025-11-18 14:49 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2025-11-18 14:49 UTC (permalink / raw)
To: David Heidelberg, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel, Casey Connolly
On 11/18/25 3:44 PM, David Heidelberg wrote:
> On 18/11/2025 15:32, Konrad Dybcio wrote:
>> On 11/18/25 3:11 PM, David Heidelberg via B4 Relay wrote:
>>> From: Casey Connolly <casey.connolly@linaro.org>
>>>
>>> The panel regulator doesn't need to be always on, so remove this
>>> property.
>>>
>>> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>> ---
>>
>> Fixes?
>
> I only know this works well at current next-202511xx, these patches we're also in sdm845-mainline downstream repo, but there was multiple different patches and hacks for panels and other stuff present, so it's hard for me verify that on clean mainline kernel these will work as expected (as older mainline versions also need the panel patched etc.)
Fixes != backports
Konrad
>
> If you insist, I can append Fixes against when these properties we're or weren't introduced (talking about PATCH 3/3 too).
>
>>
>> Konrad
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-11-18 14:49 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-18 14:11 [PATCH 0/3] Regulator adjustments for OnePlus 6 and 6T David Heidelberg via B4 Relay
2025-11-18 14:11 ` [PATCH 1/3] arm64: dts: qcom: sdm845-oneplus: Don't mark ts supply boot-on David Heidelberg via B4 Relay
2025-11-18 14:32 ` Konrad Dybcio
2025-11-18 14:11 ` [PATCH 2/3] arm64: dts: qcom: sdm845-oneplus: Don't keep panel regulator always on David Heidelberg via B4 Relay
2025-11-18 14:32 ` Konrad Dybcio
2025-11-18 14:44 ` David Heidelberg
2025-11-18 14:49 ` Konrad Dybcio
2025-11-18 14:11 ` [PATCH 3/3] arm64: dts: qcom: sdm845-oneplus: Mark l14a regulator as boot-on David Heidelberg via B4 Relay
2025-11-18 14:32 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®