From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>, Ian Campbell <ijc@hellion.org.uk>
Subject: Re: [PATCH 00 of 31] x86: unification and xen updates
Date: Wed, 19 Mar 2008 15:15:33 -0700 [thread overview]
Message-ID: <47E19085.2020308@goop.org> (raw)
In-Reply-To: <20080319220431.GA11606@elte.hu>
Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>
>>> config attached. randconfig generated, so it can have random
>>> surprises enabled :)
>>>
>> Thanks. What was the workload? Did it just happen, or were you doing
>> something specific?
>>
>
> simple bootup triggered it.
>
Haven't managed to repro it yet, but DEBUG_PAGE_ALLOC turned up another
case of doing tlb flushes with preempt on:
BUG: using smp_processor_id() in preemptible [00000000] code: init/1
caller is xen_flush_tlb+0xe/0xa2
Pid: 1, comm: init Not tainted 2.6.25-rc6-x86-latest.git #281
[<c0234eed>] debug_smp_processor_id+0x99/0xb0
[<c0103ca0>] xen_flush_tlb+0xe/0xa2
[<c011d46b>] kernel_map_pages+0x104/0x125
[<c0154f45>] get_page_from_freelist+0x32f/0x433
[<c01444c4>] ? lock_acquire+0x90/0x9d
[<c01550bd>] __alloc_pages+0x5e/0x2a5
[<c015c5b3>] do_wp_page+0x2c9/0x653
[<c017953f>] ? do_lookup+0x4f/0x146
[<c0103e11>] ? xen_restore_fl+0x2e/0x52
[<c01444c4>] ? lock_acquire+0x90/0x9d
[<c015f720>] ? handle_mm_fault+0xa37/0xbb8
[<c015f7a4>] handle_mm_fault+0xabb/0xbb8
[<c0179332>] ? path_put+0x20/0x23
[<c0103e11>] ? xen_restore_fl+0x2e/0x52
[<c0103e11>] ? xen_restore_fl+0x2e/0x52
[<c045699d>] ? do_page_fault+0x460/0x952
[<c013b80d>] ? down_read_trylock+0x37/0x41
[<c0456a51>] do_page_fault+0x514/0x952
[<c0232116>] ? copy_to_user+0x2a/0x34
[<c017e3ce>] ? sys_select+0x13e/0x164
[<c045653d>] ? do_page_fault+0x0/0x952
[<c0454eaa>] error_code+0x72/0x78
This code seems a bit fast and loose anyway, since it only does a local
TLB flush, which means that other CPUs can still accessed free memory if
they still have a stale TLB for it. Having the tlb flush happen on a
random CPU doesn't really affect things much.
J
next prev parent reply other threads:[~2008-03-19 23:50 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 23:36 Jeremy Fitzhardinge
2008-03-17 23:36 ` [PATCH 01 of 31] xen: fix RMW when unmasking events Jeremy Fitzhardinge
2008-03-17 23:36 ` [PATCH 02 of 31] xen: fix UP setup of shared_info Jeremy Fitzhardinge
2008-03-17 23:36 ` [PATCH 03 of 31] x86: convert pgalloc_64.h from macros to inlines Jeremy Fitzhardinge
2008-03-17 23:36 ` [PATCH 04 of 31] x86: add common mm/pgtable.c Jeremy Fitzhardinge
2008-03-17 23:36 ` [PATCH 05 of 31] x86: put paravirt stubs into common asm/pgalloc.h Jeremy Fitzhardinge
2008-03-17 23:36 ` [PATCH 06 of 31] x86: move pte functions " Jeremy Fitzhardinge
2008-03-17 23:36 ` [PATCH 07 of 31] x86: move pmd " Jeremy Fitzhardinge
2008-03-17 23:36 ` [PATCH 08 of 31] x86: move pgalloc pud and pgd operations into common place Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 09 of 31] x86: move all the pgd_list handling to one place Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 10 of 31] x86: rename paravirt_alloc_pt etc after the pagetable structure Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 11 of 31] x86: add pud_alloc for 4-level pagetables Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 12 of 31] x86/pgtable.h: demacro ptep_set_access_flags Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 13 of 31] x86/pgtable.h: demacro ptep_test_and_clear_young Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 14 of 31] x86/pgtable.h: demacro ptep_clear_flush_young Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 15 of 31] x86: demacro pgalloc paravirt stubs Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 16 of 31] xen: use appropriate pte types Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 17 of 31] xen: make use of pte_t union Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 18 of 31] xen: unify pte operations Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 19 of 31] xen: use phys_addr_t when referring to physical addresses Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 20 of 31] xen: unify pte operations on machine frames Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 21 of 31] xen: make sure iret faults are trapped Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 22 of 31] x86: unify KERNEL_PGD_PTRS Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 23 of 31] x86: unify pgd ctor/dtor Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 24 of 31] xen: add support for callbackops hypercall Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 25 of 31] x86: only enable interrupts when kernel state has been set up Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 26 of 31] xen: support sysenter/sysexit if hypervisor does Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 27 of 31] xen: implement a debug-interrupt handler Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 28 of 31] xen: make sure retriggered events are set pending Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 29 of 31] xen: short-cut for recursive event handling Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 30 of 31] xen: no need for domU to worry about MCE/MCA Jeremy Fitzhardinge
2008-03-17 23:37 ` [PATCH 31 of 31] xen: jump to iret fixup Jeremy Fitzhardinge
2008-03-18 21:33 ` [PATCH 00 of 31] x86: unification and xen updates Zachary Amsden
2008-03-18 21:37 ` Jeremy Fitzhardinge
2008-03-19 9:22 ` Ian Campbell
2008-03-19 15:11 ` Jeremy Fitzhardinge
2008-03-19 16:50 ` Ian Campbell
2008-03-19 18:45 ` Jeremy Fitzhardinge
2008-03-19 19:07 ` Ingo Molnar
2008-03-19 19:19 ` Jeremy Fitzhardinge
2008-03-19 19:05 ` Ingo Molnar
2008-03-19 19:46 ` Ingo Molnar
2008-03-19 20:02 ` Jeremy Fitzhardinge
2008-03-19 20:09 ` Ingo Molnar
2008-03-19 21:12 ` Jeremy Fitzhardinge
2008-03-19 21:33 ` Ingo Molnar
2008-03-19 21:54 ` Jeremy Fitzhardinge
2008-03-19 22:00 ` Ingo Molnar
2008-03-19 21:58 ` Jeremy Fitzhardinge
2008-03-19 22:04 ` Ingo Molnar
2008-03-19 22:15 ` Jeremy Fitzhardinge [this message]
2008-03-19 23:52 ` Ingo Molnar
2008-03-20 20:24 ` Jeremy Fitzhardinge
2008-03-21 13:17 ` Ingo Molnar
2008-03-21 14:35 ` Ingo Molnar
2008-03-21 15:15 ` Jeremy Fitzhardinge
2008-03-21 15:25 ` Ingo Molnar
2008-03-22 2:34 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E19085.2020308@goop.org \
--to=jeremy@goop.org \
--cc=ijc@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome