From: Jeff Garzik <jeff@garzik.org>
To: James Simmons <jsimmons@infradead.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] add random irq flag to natsemi network driver
Date: Mon, 24 Mar 2008 16:57:38 -0400 [thread overview]
Message-ID: <47E815C2.1050900@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0803241428040.22437@pentafluge.infradead.org>
James Simmons wrote:
> Please apply this patch. On the embbeded board I work on this is the only
> entropy source we have.
>
> diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
> index 385f69c..c6553dd 100644
> --- a/drivers/net/natsemi.c
> +++ b/drivers/net/natsemi.c
> @@ -1529,7 +1529,8 @@ static int netdev_open(struct net_device *dev)
> /* Reset the chip, just in case. */
> natsemi_reset(dev);
>
> - i = request_irq(dev->irq, &intr_handler, IRQF_SHARED, dev->name, dev);
> + i = request_irq(dev->irq, &intr_handler, IRQF_SHARED | IRQF_SAMPLE_RANDOM,
> + dev->name, dev);
With timed interrupt mitigation and remotely controlled interrupt
sources, this can be distinctly non-random.
This type of patch is traditionally not applied...
Jeff
prev parent reply other threads:[~2008-03-24 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 14:32 James Simmons
2008-03-24 20:57 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E815C2.1050900@garzik.org \
--to=jeff@garzik.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®