* [PATCH] add random irq flag to natsemi network driver
@ 2008-03-24 14:32 James Simmons
2008-03-24 20:57 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: James Simmons @ 2008-03-24 14:32 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux Kernel Mailing List
Please apply this patch. On the embbeded board I work on this is the only
entropy source we have.
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index 385f69c..c6553dd 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -1529,7 +1529,8 @@ static int netdev_open(struct net_device *dev)
/* Reset the chip, just in case. */
natsemi_reset(dev);
- i = request_irq(dev->irq, &intr_handler, IRQF_SHARED, dev->name, dev);
+ i = request_irq(dev->irq, &intr_handler, IRQF_SHARED | IRQF_SAMPLE_RANDOM,
+ dev->name, dev);
if (i) return i;
if (netif_msg_ifup(np))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] add random irq flag to natsemi network driver
2008-03-24 14:32 [PATCH] add random irq flag to natsemi network driver James Simmons
@ 2008-03-24 20:57 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-03-24 20:57 UTC (permalink / raw)
To: James Simmons; +Cc: Linus Torvalds, Linux Kernel Mailing List
James Simmons wrote:
> Please apply this patch. On the embbeded board I work on this is the only
> entropy source we have.
>
> diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
> index 385f69c..c6553dd 100644
> --- a/drivers/net/natsemi.c
> +++ b/drivers/net/natsemi.c
> @@ -1529,7 +1529,8 @@ static int netdev_open(struct net_device *dev)
> /* Reset the chip, just in case. */
> natsemi_reset(dev);
>
> - i = request_irq(dev->irq, &intr_handler, IRQF_SHARED, dev->name, dev);
> + i = request_irq(dev->irq, &intr_handler, IRQF_SHARED | IRQF_SAMPLE_RANDOM,
> + dev->name, dev);
With timed interrupt mitigation and remotely controlled interrupt
sources, this can be distinctly non-random.
This type of patch is traditionally not applied...
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-24 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-24 14:32 [PATCH] add random irq flag to natsemi network driver James Simmons
2008-03-24 20:57 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®