* [PATCH] tty: Fix a possible resource leak in icom_probe
@ 2022-03-31 9:10 Huang Guobin
2022-04-06 11:06 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Huang Guobin @ 2022-03-31 9:10 UTC (permalink / raw)
To: gregkh, jirislaby; +Cc: linux-serial, linux-kernel
When pci_read_config_dword failed, call pci_release_regions() and
pci_disable_device() to recycle the resource previously allocated.
Signed-off-by: Huang Guobin <huangguobin4@huawei.com>
---
drivers/tty/serial/icom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c
index 03a2fe9f4c9a..02b375ba2f07 100644
--- a/drivers/tty/serial/icom.c
+++ b/drivers/tty/serial/icom.c
@@ -1501,7 +1501,7 @@ static int icom_probe(struct pci_dev *dev,
retval = pci_read_config_dword(dev, PCI_COMMAND, &command_reg);
if (retval) {
dev_err(&dev->dev, "PCI Config read FAILED\n");
- return retval;
+ goto probe_exit0;
}
pci_write_config_dword(dev, PCI_COMMAND,
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] tty: Fix a possible resource leak in icom_probe
2022-03-31 9:10 [PATCH] tty: Fix a possible resource leak in icom_probe Huang Guobin
@ 2022-04-06 11:06 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2022-04-06 11:06 UTC (permalink / raw)
To: Huang Guobin, gregkh; +Cc: linux-serial, linux-kernel
On 31. 03. 22, 11:10, Huang Guobin wrote:
> When pci_read_config_dword failed, call pci_release_regions() and
> pci_disable_device() to recycle the resource previously allocated.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Huang Guobin <huangguobin4@huawei.com>
> ---
> drivers/tty/serial/icom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c
> index 03a2fe9f4c9a..02b375ba2f07 100644
> --- a/drivers/tty/serial/icom.c
> +++ b/drivers/tty/serial/icom.c
> @@ -1501,7 +1501,7 @@ static int icom_probe(struct pci_dev *dev,
> retval = pci_read_config_dword(dev, PCI_COMMAND, &command_reg);
> if (retval) {
> dev_err(&dev->dev, "PCI Config read FAILED\n");
> - return retval;
> + goto probe_exit0;
> }
>
> pci_write_config_dword(dev, PCI_COMMAND,
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31 9:10 [PATCH] tty: Fix a possible resource leak in icom_probe Huang Guobin
2022-04-06 11:06 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®