From: Andrew Lunn <andrew@lunn.ch>
To: Yibo Dong <dong100@mucse.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
corbet@lwn.net, gur.stavi@huawei.com, maddy@linux.ibm.com,
mpe@ellerman.id.au, danishanwar@ti.com, lee@trager.us,
gongfan1@huawei.com, lorenzo@kernel.org, geert+renesas@glider.be,
Parthiban.Veerasooran@microchip.com, lukas.bulwahn@redhat.com,
alexanderduyck@fb.com, richardcochran@gmail.com,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/5] net: rnpgbe: Add basic mbx_fw support
Date: Thu, 21 Aug 2025 05:13:27 +0200 [thread overview]
Message-ID: <47aa140e-552b-4650-9031-8931475f0719@lunn.ch> (raw)
In-Reply-To: <458C8E59A94CE79B+20250821024916.GF1742451@nic-Precision-5820-Tower>
> 'mucse_mbx_fw_post_req' is designed can be called by 'cat /sys/xxx',
It is pretty unusual for ethernet drivers to export data in /sys,
except via standard APIs, like statistics, carrier, address, opstate
etc. I don't know how well the core will handle EINTR. It is not
something most drivers do. -ETIMEDOUT is more likely when the firmware
has crashed and does not respond in time.
Do you have any operations which take a long time when things are
working correctly?
Andrew
next prev parent reply other threads:[~2025-08-21 3:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 11:28 [PATCH v5 0/5] Add driver for 1Gbe network chips from MUCSE Dong Yibo
2025-08-18 11:28 ` [PATCH v5 1/5] net: rnpgbe: Add build support for rnpgbe Dong Yibo
2025-08-20 20:06 ` Andrew Lunn
2025-08-21 1:29 ` Yibo Dong
2025-08-21 3:00 ` Andrew Lunn
2025-08-18 11:28 ` [PATCH v5 2/5] net: rnpgbe: Add n500/n210 chip support Dong Yibo
2025-08-19 13:59 ` Vadim Fedorenko
2025-08-20 1:43 ` Yibo Dong
2025-08-20 20:10 ` Andrew Lunn
2025-08-21 1:53 ` Yibo Dong
2025-08-20 20:16 ` Andrew Lunn
2025-08-21 1:54 ` Yibo Dong
2025-08-18 11:28 ` [PATCH v5 3/5] net: rnpgbe: Add basic mbx ops support Dong Yibo
2025-08-20 20:23 ` Andrew Lunn
2025-08-21 1:44 ` Yibo Dong
2025-08-21 3:06 ` Andrew Lunn
2025-08-21 3:51 ` Yibo Dong
2025-08-18 11:28 ` [PATCH v5 4/5] net: rnpgbe: Add basic mbx_fw support Dong Yibo
2025-08-20 20:30 ` Andrew Lunn
2025-08-21 2:04 ` Yibo Dong
2025-08-20 20:37 ` Andrew Lunn
2025-08-21 2:49 ` Yibo Dong
2025-08-21 3:13 ` Andrew Lunn [this message]
2025-08-21 3:32 ` Yibo Dong
2025-08-22 19:52 ` Andrew Lunn
2025-08-23 1:12 ` Yibo Dong
2025-08-18 11:28 ` [PATCH v5 5/5] net: rnpgbe: Add register_netdev Dong Yibo
2025-08-20 20:42 ` Andrew Lunn
2025-08-21 3:43 ` Yibo Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47aa140e-552b-4650-9031-8931475f0719@lunn.ch \
--to=andrew@lunn.ch \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=gongfan1@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®