mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Yibo Dong <dong100@mucse.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	corbet@lwn.net, gur.stavi@huawei.com, maddy@linux.ibm.com,
	mpe@ellerman.id.au, danishanwar@ti.com, lee@trager.us,
	gongfan1@huawei.com, lorenzo@kernel.org, geert+renesas@glider.be,
	Parthiban.Veerasooran@microchip.com, lukas.bulwahn@redhat.com,
	alexanderduyck@fb.com, richardcochran@gmail.com,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/5] net: rnpgbe: Add basic mbx_fw support
Date: Fri, 22 Aug 2025 21:52:25 +0200	[thread overview]
Message-ID: <d7a38afc-58c1-468a-be47-442cec6db728@lunn.ch> (raw)
In-Reply-To: <7FCBCC1F18AFE0F3+20250821033253.GA1754449@nic-Precision-5820-Tower>

> 'Update firmware operation' will take long time, maybe more than
> 10s. If user use 'ethtool -f' to update firmware, and ^C before done?
> If ^C before mucse_write_mbx, return as soon as possible. If after mucse_write_mbx,
> wait until fw true response.

And what happens if the firmware writing is interrupted? Could you end
up with a brick? This is actually one of the operations i would not
expect to be able to ^C.

You might also want consider devlink flash.

https://www.kernel.org/doc/html/latest/networking/devlink/devlink-flash.html

 It replaces the older ethtool-flash mechanism, and doesn’t require
 taking any networking locks in the kernel to perform the flash
 update.

I assume this is meaning ethtool take RTNL, and while that is held, no
other network configuration can be performed on any interface. devlink
has its own lock so avoids this.

       Andrew

  reply	other threads:[~2025-08-22 19:53 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 11:28 [PATCH v5 0/5] Add driver for 1Gbe network chips from MUCSE Dong Yibo
2025-08-18 11:28 ` [PATCH v5 1/5] net: rnpgbe: Add build support for rnpgbe Dong Yibo
2025-08-20 20:06   ` Andrew Lunn
2025-08-21  1:29     ` Yibo Dong
2025-08-21  3:00       ` Andrew Lunn
2025-08-18 11:28 ` [PATCH v5 2/5] net: rnpgbe: Add n500/n210 chip support Dong Yibo
2025-08-19 13:59   ` Vadim Fedorenko
2025-08-20  1:43     ` Yibo Dong
2025-08-20 20:10       ` Andrew Lunn
2025-08-21  1:53         ` Yibo Dong
2025-08-20 20:16   ` Andrew Lunn
2025-08-21  1:54     ` Yibo Dong
2025-08-18 11:28 ` [PATCH v5 3/5] net: rnpgbe: Add basic mbx ops support Dong Yibo
2025-08-20 20:23   ` Andrew Lunn
2025-08-21  1:44     ` Yibo Dong
2025-08-21  3:06       ` Andrew Lunn
2025-08-21  3:51         ` Yibo Dong
2025-08-18 11:28 ` [PATCH v5 4/5] net: rnpgbe: Add basic mbx_fw support Dong Yibo
2025-08-20 20:30   ` Andrew Lunn
2025-08-21  2:04     ` Yibo Dong
2025-08-20 20:37   ` Andrew Lunn
2025-08-21  2:49     ` Yibo Dong
2025-08-21  3:13       ` Andrew Lunn
2025-08-21  3:32         ` Yibo Dong
2025-08-22 19:52           ` Andrew Lunn [this message]
2025-08-23  1:12             ` Yibo Dong
2025-08-18 11:28 ` [PATCH v5 5/5] net: rnpgbe: Add register_netdev Dong Yibo
2025-08-20 20:42   ` Andrew Lunn
2025-08-21  3:43     ` Yibo Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7a38afc-58c1-468a-be47-442cec6db728@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Parthiban.Veerasooran@microchip.com \
    --cc=alexanderduyck@fb.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=danishanwar@ti.com \
    --cc=davem@davemloft.net \
    --cc=dong100@mucse.com \
    --cc=edumazet@google.com \
    --cc=geert+renesas@glider.be \
    --cc=gongfan1@huawei.com \
    --cc=gur.stavi@huawei.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lee@trager.us \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=lukas.bulwahn@redhat.com \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®