From: Vineeth Remanan Pillai <vineethp@amazon.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM
Date: Thu, 19 Jan 2017 09:17:09 -0800 [thread overview]
Message-ID: <47b20f33-2fbe-c4f7-68dc-994073dd5105@amazon.com> (raw)
In-Reply-To: <20170119.121137.735637643552808729.davem@davemloft.net>
On 01/19/2017 09:11 AM, David Miller wrote:
> From: Vineeth Remanan Pillai <vineethp@amazon.com>
> Date: Thu, 19 Jan 2017 08:35:39 -0800
>
>> From: Vineeth Remanan Pillai <vineethp@amazon.com>
>>
>> During an OOM scenario, request slots could not be created as skb
>> allocation fails. So the netback cannot pass in packets and netfront
>> wrongly assumes that there is no more work to be done and it disables
>> polling. This causes Rx to stall.
>>
>> The issue is with the retry logic which schedules the timer if the
>> created slots are less than NET_RX_SLOTS_MIN. The count of new request
>> slots to be pushed are calculated as a difference between new req_prod
>> and rsp_cons which could be more than the actual slots, if there are
>> unconsumed responses.
>>
>> The fix is to calculate the count of newly created slots as the
>> difference between new req_prod and old req_prod.
>>
>> Signed-off-by: Vineeth Remanan Pillai <vineethp@amazon.com>
>> Reviewed-by: Juergen Gross <jgross@suse.com>
>> ---
>> Changes in v2:
>> - Removed the old implementation of enabling polling on
>> skb allocation error.
>> - Corrected the refill timer logic to schedule when newly
>> created slots since last push is less than NET_RX_SLOTS_MIN.
> Your postings aren't showing up on vger.kernel.org at all.
>
> Are you getting a bounce message back? I can only assume you are triggering
> one of the various content filters we have.
>
I haven't received any bounce messages till now. The mail showed up
in xen-devel after about 8 hours yesterday. Not sure what is happening
with vger.kernel.org. My initial patch showed up in all the mailing
list. The
only difference is, I switched to a machine running a later version of git.
Should I try sending it once again?
Thanks
next prev parent reply other threads:[~2017-01-19 18:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1484771149-12699-1-git-send-email-vineethp@u480fcf3b67f557f68df1.ant.amazon.com>
2017-01-19 16:35 ` Vineeth Remanan Pillai
2017-01-19 17:11 ` David Miller
2017-01-19 17:17 ` Vineeth Remanan Pillai [this message]
2017-01-19 18:10 ` David Miller
2017-01-20 19:09 ` David Miller
2017-01-29 23:09 ` Boris Ostrovsky
2017-01-30 16:47 ` Vineeth Remanan Pillai
2017-01-30 17:06 ` Boris Ostrovsky
2017-01-30 17:13 ` Vineeth Remanan Pillai
2017-01-31 16:47 ` Vineeth Remanan Pillai
2017-01-12 23:09 [PATCH] " Vineeth Remanan Pillai
[not found] ` <1484330100-3960-1-git-send-email-vineethp@u480fcf3b67f557f68df1.ant.amazon.com>
2017-01-16 6:24 ` [PATCH v2] " Juergen Gross
2017-01-18 17:02 ` Vineeth Remanan Pillai
2017-01-18 20:08 ` David Miller
2017-01-18 20:10 ` David Miller
2017-01-18 20:24 ` Vineeth Remanan Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47b20f33-2fbe-c4f7-68dc-994073dd5105@amazon.com \
--to=vineethp@amazon.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®