* [PATCH] tty: serial: atmel: Add COMMON_CLK dependency to SERIAL_ATMEL
@ 2022-09-26 14:32 Sergiu Moga
2022-09-26 15:37 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Sergiu Moga @ 2022-09-26 14:32 UTC (permalink / raw)
To: gregkh, jirislaby, sergiu.moga, claudiu.beznea, richard.genoud,
nicolas.ferre
Cc: linux-serial, linux-kernel, kernel test robot
Now that the driver makes use of `__clk_is_enabled()` in order to
know whether a `clk_disable_unprepare()` is needed or not on the
GCLK, a new dependency has been introduced: COMMON_CLK. If this
`CONFIG_COMMON_CLK` is not enabled, whatever config may have this
driver enabled without COMMON_CLK then an undefined reference to
`__clk_is_enabled()` will be issued by the linker.
Thus, make sure that, unless `CONFIG_COMMON_CLK` is enabled, this
driver is not compiled.
Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
---
drivers/tty/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index a18dd525e42b..1aec3cf002f7 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -127,6 +127,7 @@ config SERIAL_SB1250_DUART_CONSOLE
config SERIAL_ATMEL
bool "AT91 on-chip serial port support"
+ depends on COMMON_CLK
depends on ARCH_AT91 || COMPILE_TEST
select SERIAL_CORE
select SERIAL_MCTRL_GPIO if GPIOLIB
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] tty: serial: atmel: Add COMMON_CLK dependency to SERIAL_ATMEL
2022-09-26 14:32 [PATCH] tty: serial: atmel: Add COMMON_CLK dependency to SERIAL_ATMEL Sergiu Moga
@ 2022-09-26 15:37 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2022-09-26 15:37 UTC (permalink / raw)
To: Sergiu Moga, gregkh, jirislaby, claudiu.beznea, richard.genoud,
linux-serial
Cc: linux-kernel, kernel test robot
On 26/09/2022 at 16:32, Sergiu Moga wrote:
> Now that the driver makes use of `__clk_is_enabled()` in order to
> know whether a `clk_disable_unprepare()` is needed or not on the
> GCLK, a new dependency has been introduced: COMMON_CLK. If this
> `CONFIG_COMMON_CLK` is not enabled, whatever config may have this
> driver enabled without COMMON_CLK then an undefined reference to
> `__clk_is_enabled()` will be issued by the linker.
>
> Thus, make sure that, unless `CONFIG_COMMON_CLK` is enabled, this
> driver is not compiled.
>
> Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/tty/serial/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index a18dd525e42b..1aec3cf002f7 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -127,6 +127,7 @@ config SERIAL_SB1250_DUART_CONSOLE
>
> config SERIAL_ATMEL
> bool "AT91 on-chip serial port support"
> + depends on COMMON_CLK
> depends on ARCH_AT91 || COMPILE_TEST
> select SERIAL_CORE
> select SERIAL_MCTRL_GPIO if GPIOLIB
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-26 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 14:32 [PATCH] tty: serial: atmel: Add COMMON_CLK dependency to SERIAL_ATMEL Sergiu Moga
2022-09-26 15:37 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®