From: Joe Perches <joe@perches.com>
To: Markus Elfring <Markus.Elfring@web.de>,
linux-s390@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: "Christian Bornträger" <borntraeger@de.ibm.com>,
"Harald Freudenberger" <freude@linux.ibm.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
"Ingo Franzki" <ifranzki@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: s390/pkey: Use memdup_user() rather than duplicating its implementation
Date: Wed, 06 Nov 2019 09:29:31 -0800 [thread overview]
Message-ID: <47c55ab899aafe10898e6581582363aa446b2091.camel@perches.com> (raw)
In-Reply-To: <0f90b278-7b3e-6509-1633-301d16513c5d@web.de>
On Wed, 2019-11-06 at 14:00 +0100, Markus Elfring wrote:
> > > Reuse existing functionality from memdup_user() instead of keeping
> > > duplicate source code.
> > >
> > > Generated by: scripts/coccinelle/api/memdup_user.cocci
> …
> > > Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support")
> >
> > This doesn't fix anything
>
> How would you categorise the proposed source code reduction and software reuse?
As inappropriate for a fixes tag.
The fixes tag is "used to make it easy to determine where a bug
originated, which can help review a bug fix"
There is no bug here.
> Will the development opinions vary between contributors?
Ever had a bikeshed?
> > > + return !ukey || keylen < MINKEYBLOBSIZE || keylen > KEYBLOBBUFSIZE
> > > + ? ERR_PTR(-EINVAL)
> > > + : memdup_user(ukey, keylen);
> >
> > This is a very poor use of ternary ?: code.
>
> The conditional operator is applied once more in the intended way,
> isn't it?
Please take your development efforts to obfuscated c contests.
next prev parent reply other threads:[~2019-11-06 17:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 10:22 [PATCH] " Markus Elfring
2019-11-06 10:38 ` Joe Perches
2019-11-06 13:00 ` Markus Elfring
2019-11-06 18:30 ` Christian Borntraeger
2019-11-07 6:48 ` Dan Carpenter
2019-11-07 8:07 ` Christian Borntraeger
2019-11-06 13:00 ` Markus Elfring
2019-11-06 17:29 ` Joe Perches [this message]
2019-11-06 18:55 ` Markus Elfring
2019-11-06 19:01 ` Joe Perches
2019-11-06 19:18 ` Markus Elfring
2019-11-07 10:06 ` [PATCH v2] " Markus Elfring
2019-11-07 12:44 ` Christian Borntraeger
2019-11-07 13:45 ` Markus Elfring
2019-11-07 13:54 ` Christian Borntraeger
2019-11-07 14:27 ` Markus Elfring
2019-11-08 11:32 ` Christian Borntraeger
2019-11-08 17:14 ` [PATCH v3] " Markus Elfring
2019-11-11 7:54 ` Christian Borntraeger
2019-11-11 8:11 ` [v3] " Markus Elfring
2019-11-11 8:27 ` Christian Borntraeger
2019-11-11 8:42 ` Markus Elfring
2019-11-11 8:56 ` Christian Borntraeger
2019-11-11 9:06 ` Markus Elfring
2019-11-11 9:08 ` Christian Borntraeger
2019-11-11 9:17 ` Markus Elfring
2019-11-11 9:18 ` Christian Borntraeger
2019-11-11 9:26 ` Markus Elfring
2019-11-11 14:45 ` [PATCH v4] s390/pkey: Fix memory leak in error case by using memdup_user() rather than open coding Markus Elfring
2019-11-11 16:40 ` Christian Borntraeger
2019-11-13 17:09 ` [v4] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47c55ab899aafe10898e6581582363aa446b2091.camel@perches.com \
--to=joe@perches.com \
--cc=Markus.Elfring@web.de \
--cc=borntraeger@de.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=ifranzki@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®