mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] pmdomain: mediatek: mtk-mfg: select MAILBOX in Kconfig
@ 2025-10-30 13:17 Nicolas Frattaroli
  2025-10-30 15:17 ` AngeloGioacchino Del Regno
  2025-11-04 16:33 ` Ulf Hansson
  0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Frattaroli @ 2025-10-30 13:17 UTC (permalink / raw)
  To: Ulf Hansson, Matthias Brugger, AngeloGioacchino Del Regno
  Cc: linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek, kernel,
	kernel test robot, Nicolas Frattaroli

The mtk-mfg pmdomain driver calls common mailbox framework functions. If
the common mailbox framework is not selected in the kernel's
configuration, the build runs into a linker error, as the symbols are
absent.

The hardware mailbox Kconfig system, MAILBOX, has no dependencies of its
own. It's therefore safe to "select" it rather than use "depend on".

Declare this "select" dependency in the Kconfig for the driver.

Fixes: 1ff1f0db6aec ("pmdomain: mediatek: Add support for MFlexGraphics")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510301311.TcOCnZ1s-lkp@intel.com/
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
I assume this can be squashed into the mtk-mfg driver addition commit of
the maintainer that merged it.
---
 drivers/pmdomain/mediatek/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pmdomain/mediatek/Kconfig b/drivers/pmdomain/mediatek/Kconfig
index b06aaa9690f0..8923e6516441 100644
--- a/drivers/pmdomain/mediatek/Kconfig
+++ b/drivers/pmdomain/mediatek/Kconfig
@@ -32,6 +32,7 @@ config MTK_MFG_PM_DOMAIN
 	depends on PM
 	depends on OF
 	depends on COMMON_CLK
+	select MAILBOX
 	select PM_GENERIC_DOMAINS
 	imply MTK_GPUEB_MBOX
 	help

---
base-commit: d78b0fee454c25d292fb6343253eca06d7634fd9
change-id: 20251030-mfg-mailbox-dep-ec32ef510e6a

Best regards,
-- 
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-04 16:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-30 13:17 [PATCH] pmdomain: mediatek: mtk-mfg: select MAILBOX in Kconfig Nicolas Frattaroli
2025-10-30 15:17 ` AngeloGioacchino Del Regno
2025-11-04 16:33 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®