mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Adrian Bunk <bunk@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Harvey Harrison <harvey.harrison@gmail.com>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: If you want me to quit I will quit
Date: Sat, 26 Apr 2008 20:51:39 +0200	[thread overview]
Message-ID: <481379BB.5050208@s5r6.in-berlin.de> (raw)
In-Reply-To: <alpine.LFD.1.10.0804261024580.2813@woody.linux-foundation.org>

Linus Torvalds wrote:
> But it's not a hard rule. Sometimes simple cleanliness means that you can 
> decide to go "oops, that was *really* wrong, let's just throw that away 
> and do a whole new set of patches". But it should be something rare - not 
> normal coding practice.

Well, the need to amend single patches --- and folding the amendment in 
before mainline submission to correct important problems of the first 
shot --- is something which happens all the time.

(People will have different opinions about what is important enough to 
redo a patch instead of keeping the amendment separate.)

> Because if it becomes normal coding practice, now people cannot work with 
> you sanely any more (ie some random person pulls your tree for testing, 
> and then I pull it at some other time, and the tester reports a problem, 
> but now the commits he is talking about don't actually even exist in my 
> tree any more, and it's all really messy!).

In my experience, the submission branch cannot practically be the same 
as the development branch (I mean, a true ancestor of the of the 
development branch).  That's simply because the order of submission is 
different.

The only way to keep commits from the development branch identical in 
the submission branch would be to work with a huge number of topic 
branches, with the number of branches approaching the number of commits. 
But then testers and developers would still work with merge commits 
which will not appear in the mainline submission.  And there would be 
weird histories because of the need to merge from other trees, notably 
from torvalds/linux-2.6.git when necessary to avoid conflicts.

(I for one rebuild the development branch of linux1394-2.6.git from 
scratch after 2.6.x-rc1 came out, then keep its history until 2.6.x. 
During that time I occasionally 'pollute' it with reverts and with 
merges from torvalds/linux-2.6.git.  These will not be carried over into 
the submission branch.)
-- 
Stefan Richter
-=====-==--- -=-- ==-=-
http://arcgraph.de/sr/

  parent reply	other threads:[~2008-04-26 18:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26  6:14 [BUILDFIX PATCH] au0828: debug is a poor global identifier Harvey Harrison
2008-04-26 11:00 ` If you want me to quit I will quit Adrian Bunk
2008-04-26 11:27   ` Sam Ravnborg
2008-04-26 14:44     ` Adrian Bunk
2008-04-26 16:51       ` Linus Torvalds
2008-04-26 17:09         ` Adrian Bunk
2008-04-26 17:21           ` Linus Torvalds
2008-04-26 17:35             ` Adrian Bunk
2008-04-26 17:56               ` Linus Torvalds
2008-04-26 14:51   ` Andrew Morton
2008-04-26 15:23     ` Adrian Bunk
2008-04-26 15:44       ` Andrew Morton
2008-04-26 17:16         ` Adrian Bunk
2008-04-26 17:20           ` Andrew Morton
2008-04-26 17:27             ` Adrian Bunk
2008-04-26 17:35               ` Linus Torvalds
2008-04-26 17:31           ` Linus Torvalds
2008-04-26 17:42             ` Sam Ravnborg
2008-04-26 18:26               ` Linus Torvalds
2008-04-26 18:51             ` Stefan Richter [this message]
2008-04-26 19:05               ` Linus Torvalds
2008-04-26 19:18                 ` Linus Torvalds
2008-04-26 20:30                   ` Andrew Morton
2008-04-26 20:35                     ` Linus Torvalds
2008-04-28 19:05                       ` Romano Giannetti
2008-04-26 20:49                     ` Stefan Richter
2008-04-27 12:07                     ` Richard Purdie
2008-04-27 14:28                       ` Stefan Richter
2008-04-26 19:43                 ` Stefan Richter
2008-04-27  0:31             ` David Miller
2008-04-27  2:58               ` Jeff Garzik
2008-04-27 16:09             ` Ingo Molnar
2008-04-26 16:21   ` Bartlomiej Zolnierkiewicz
2008-04-26 17:10   ` Adrian Bunk
2008-04-26 19:20   ` Harvey Harrison
2008-04-26 19:42     ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481379BB.5050208@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=harvey.harrison@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®