From: Linus Torvalds <torvalds@linux-foundation.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Adrian Bunk <bunk@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Harvey Harrison <harvey.harrison@gmail.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: If you want me to quit I will quit
Date: Sat, 26 Apr 2008 12:05:06 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0804261153390.2813@woody.linux-foundation.org> (raw)
In-Reply-To: <481379BB.5050208@s5r6.in-berlin.de>
On Sat, 26 Apr 2008, Stefan Richter wrote:
>
> Well, the need to amend single patches --- and folding the amendment in before
> mainline submission to correct important problems of the first shot --- is
> something which happens all the time.
.. and you simply SHOULD NOT PUBLICIZE the tree before it has gotten to a
reasonable point.
Keep the rough-and-not-ready thing that is being discussed as patches on
lkml as your own working tree, and just don't expose it as a public git
branch. You can't do any sane discussion over git anyway - if things are
being actively worked-on among people, you'd be passing patches around as
emails etc.
Yes, people may be (and I would strongly suggest _should_ be) using
something like git or quilt etc to keep track of the patches that they
(and others) have been discussing over email, but that has absolutely
nothing to do with making a public git tree available to others.
So:
- making things public is *different* from developing them. Don't push
out just because you committed something!
- you shouldn't publicize a tree until it's in reasonable shape. EVER.
Even -mm or -next is *not* better off with a pile of sh*t just because
you're working in that area.
I cannot stress this enough. I think Andrew has been way too polite to
some people.
- and once it is, you generally shouldn't mess with old commits even when
you fix things. Full cleanliness or always being able to bisect
specific configurations is not an excuse for messing up all the other
things, and if this problem happens a lot, I would like to point you to
the two previous points.
Really.
Linus
next prev parent reply other threads:[~2008-04-26 19:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 6:14 [BUILDFIX PATCH] au0828: debug is a poor global identifier Harvey Harrison
2008-04-26 11:00 ` If you want me to quit I will quit Adrian Bunk
2008-04-26 11:27 ` Sam Ravnborg
2008-04-26 14:44 ` Adrian Bunk
2008-04-26 16:51 ` Linus Torvalds
2008-04-26 17:09 ` Adrian Bunk
2008-04-26 17:21 ` Linus Torvalds
2008-04-26 17:35 ` Adrian Bunk
2008-04-26 17:56 ` Linus Torvalds
2008-04-26 14:51 ` Andrew Morton
2008-04-26 15:23 ` Adrian Bunk
2008-04-26 15:44 ` Andrew Morton
2008-04-26 17:16 ` Adrian Bunk
2008-04-26 17:20 ` Andrew Morton
2008-04-26 17:27 ` Adrian Bunk
2008-04-26 17:35 ` Linus Torvalds
2008-04-26 17:31 ` Linus Torvalds
2008-04-26 17:42 ` Sam Ravnborg
2008-04-26 18:26 ` Linus Torvalds
2008-04-26 18:51 ` Stefan Richter
2008-04-26 19:05 ` Linus Torvalds [this message]
2008-04-26 19:18 ` Linus Torvalds
2008-04-26 20:30 ` Andrew Morton
2008-04-26 20:35 ` Linus Torvalds
2008-04-28 19:05 ` Romano Giannetti
2008-04-26 20:49 ` Stefan Richter
2008-04-27 12:07 ` Richard Purdie
2008-04-27 14:28 ` Stefan Richter
2008-04-26 19:43 ` Stefan Richter
2008-04-27 0:31 ` David Miller
2008-04-27 2:58 ` Jeff Garzik
2008-04-27 16:09 ` Ingo Molnar
2008-04-26 16:21 ` Bartlomiej Zolnierkiewicz
2008-04-26 17:10 ` Adrian Bunk
2008-04-26 19:20 ` Harvey Harrison
2008-04-26 19:42 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0804261153390.2813@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome