mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Alistair John Strachan <alistair@devzero.co.uk>,
	Robin Holt <holt@sgi.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.26-rc1
Date: Tue, 06 May 2008 16:34:27 +0200	[thread overview]
Message-ID: <48206C73.80509@s5r6.in-berlin.de> (raw)
In-Reply-To: <20080506073134.424780a3@gaivota>

Mauro Carvalho Chehab wrote:
> the Kconfig logic for V4L/DVB is complex. It tries to address two
> different issues:
> 	- an easy board selection for the end-user (just selecting CX88 should
> allow his board to work);
> 	- an advanced selection for embedded set-top-boxes, where you can
> select just what you really need.
> 
> Due to that, there are several "select" clauses, that don't consider the
> "depends on". So, it is very easy to break it, unfortunately.

No, it is not easy to break, it /is/ broken.

But it is /trivial/ to fix.  If A selects B, you have to copy all of B's
dependencies to A or select these dependencies by A.

So it's totally simple to do it right.  The only nuisance is that you
always have to update B's dependencies and selections whenever A's
dependencies are changed.

Furthermore:  If you are worried that people don't figure out how to
switch on support for board XYZ because it has several dependencies
which may hide CONFIG_XYZ, there is a very simple trick.

comment "XYZ cards need ABC"
	depends on ABC=n

config XYZ
	tristate "XYZ cards"
	depends on ABC

This way you avoid "select ABC", but still see how to get XYZ support
while ABC is off.  See for example drivers/ieee1394/Kconfig for an
application of this comment trick.
-- 
Stefan Richter
-=====-==--- -=-= --==-
http://arcgraph.de/sr/

  reply	other threads:[~2008-05-06 14:35 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8287f540805041818g534c4e02qaadb0e749c5f3439@mail.gmail.com>
2008-05-03 19:38 ` Linus Torvalds
2008-05-03 21:47   ` Alistair John Strachan
2008-05-03 21:53     ` Alistair John Strachan
2008-05-04 12:30       ` Robin Holt
2008-05-04 13:56         ` Alistair John Strachan
2008-05-04 16:09           ` Robin Holt
2008-05-04 16:33             ` Alistair John Strachan
2008-05-05 21:04             ` Mauro Carvalho Chehab
2008-05-06  8:02               ` Alistair John Strachan
2008-05-06 10:31                 ` Mauro Carvalho Chehab
2008-05-06 14:34                   ` Stefan Richter [this message]
2008-05-06 14:54                     ` Stefan Richter
2008-05-06 19:13                     ` Mauro Carvalho Chehab
2008-05-06 19:44                       ` Stefan Richter
2008-05-06 20:06                         ` Mauro Carvalho Chehab
2008-05-06 20:47                           ` Stefan Richter
2008-05-06 22:39                             ` Mauro Carvalho Chehab
2008-05-06 23:36                               ` Stefan Richter
2008-05-08 12:48                                 ` Mauro Carvalho Chehab
2008-05-08 14:11                                   ` Stefan Richter
2008-05-06 23:48                             ` Stefan Richter
2008-05-04  7:29   ` [patch] sysfs: build fix Ingo Molnar
2008-05-04 18:40   ` Linux 2.6.26-rc1 Jan Engelhardt
2008-05-05  5:39   ` Andreas Mohr
2008-05-05  7:30     ` Ingo Molnar
2008-05-05 20:14       ` Mauro Carvalho Chehab
2008-05-06 13:07         ` Ingo Molnar
2008-05-07  8:35           ` Ingo Molnar
2008-05-05 23:51       ` Stephen Rothwell
2008-05-05 23:55         ` David Miller
2008-05-06  0:16           ` Andrew Morton
2008-05-06  5:57             ` Stephen Rothwell
2008-05-06  0:21           ` Ingo Molnar
2008-05-06  5:35           ` Stephen Rothwell
2008-05-06  6:56             ` David Miller
2008-05-06  7:26               ` Stephen Rothwell
2008-05-06  0:17         ` Ingo Molnar
2008-05-06  5:48           ` Stephen Rothwell
2008-05-06  6:07   ` Scheduling problems ? [ Was: Linux 2.6.26-rc1 ] J.A. Magallón
2008-05-06 13:11     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48206C73.80509@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=alistair@devzero.co.uk \
    --cc=holt@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®