From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org, mpm@selenic.com,
lethal@linux-sh.org, dhowells@redhat.com
Subject: Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocator pass-through
Date: Wed, 21 May 2008 21:56:13 +0300 [thread overview]
Message-ID: <4834704D.6020809@cs.helsinki.fi> (raw)
In-Reply-To: <Pine.LNX.4.64.0805211149210.16064@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> Why is it too big? Without your additions it is converting kmallocs
> inline to get_free_pages(). That results in a simple function call with
> two constant parameters.
Well, it's a PITA because of #include dependencies in any case. Is
moving it out-of-line a problem?
Christoph Lameter wrote:
> The patch touches the page struct uselessly. I think the PageSlab marking
> is useful for debugging but not for a production kernel.
Hmm, where? page_address() already references ->virtual. I suppose
CONFIG_SLUB_DEBUG is a no no as well then so do we want to add a
CONFIG_KSIZE_DEBUG config option...? (Btw, I removed the BUG_ON() from
kfree() as spotted by Vegard Nossum.)
Pekka
next prev parent reply other threads:[~2008-05-21 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 18:25 Pekka J Enberg
2008-05-21 18:52 ` Christoph Lameter
2008-05-21 18:56 ` Pekka Enberg [this message]
2008-05-21 21:14 ` Christoph Lameter
2008-05-21 21:15 ` Pekka Enberg
2008-05-21 21:18 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4834704D.6020809@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®