From: Christoph Lameter <clameter@sgi.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org, mpm@selenic.com,
lethal@linux-sh.org, dhowells@redhat.com
Subject: Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocator pass-through
Date: Wed, 21 May 2008 11:52:25 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0805211149210.16064@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0805212125310.22291@sbz-30.cs.Helsinki.FI>
On Wed, 21 May 2008, Pekka J Enberg wrote:
> This patch changes ksize() to be more strict with objets passed to it. We now
> set PageSlab also for objects allocated with page allocator and use page->slab
> to check whether page is a regular slab page or a pass-through page.
>
> Also moves kmalloc_large() out-of-line as it's too big for inlining now.
Why is it too big? Without your additions it is converting kmallocs
inline to get_free_pages(). That results in a simple function call with
two constant parameters.
The patch touches the page struct uselessly. I think the PageSlab marking
is useful for debugging but not for a production kernel.
next prev parent reply other threads:[~2008-05-21 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 18:25 Pekka J Enberg
2008-05-21 18:52 ` Christoph Lameter [this message]
2008-05-21 18:56 ` Pekka Enberg
2008-05-21 21:14 ` Christoph Lameter
2008-05-21 21:15 ` Pekka Enberg
2008-05-21 21:18 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805211149210.16064@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®