Re: [PATCH v10 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

[Yijie Yang <yijie.yang@oss.qualcomm.com>]

On 2025-09-09 16:31, Konrad Dybcio wrote:
> On 9/9/25 5:56 AM, Yijie Yang wrote:
>> The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of
>> the Hamoa IoT SoM and a carrier board. Together, they form a complete
>> embedded system capable of booting to UART.
>>
>> Make the following peripherals on the carrier board enabled:
>> - UART
>> - On-board regulators
>> - USB Type-C mux
>> - Pinctrl
>> - Embedded USB (EUSB) repeaters
>> - NVMe
>> - pmic-glink
>> - USB DisplayPorts
>> - Bluetooth
>> - WLAN
>> - Audio
>>
>> Written in collaboration with Quill Qi (Audio) <le.qi@oss.qualcomm.com>,
>> Jie Zhang (Graphics) <quic_jiezh@quicinc.com>, Shuai Zhang (Bluetooth)
>> <quic_shuaz@quicinc.com>, Yingying Tang (WLAN) <quic_yintang@quicinc.com>,
>> and Yongxing Mou (USB DisplayPorts) <quic_yongmou@quicinc.com>.
>>
>> Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
>> ---
> 
> [...]
> 
>> +	sound {
>> +		compatible = "qcom,x1e80100-sndcard";
>> +		model = "X1E80100-EVK";
>> +		audio-routing = "WooferLeft IN",
>> +				"WSA WSA_SPK1 OUT",
>> +				"TweeterLeft IN",
>> +				"WSA WSA_SPK2 OUT",
>> +				"WooferRight IN",
>> +				"WSA2 WSA_SPK2 OUT",
>> +				"TweeterRight IN",
>> +				"WSA2 WSA_SPK2 OUT",
>> +				"IN1_HPHL",
>> +				"HPHL_OUT",
>> +				"IN2_HPHR",
>> +				"HPHR_OUT",
>> +				"AMIC2",
>> +				"MIC BIAS2",
>> +				"VA DMIC0",
>> +				"MIC BIAS3",
>> +				"VA DMIC1",
>> +				"MIC BIAS3",
>> +				"VA DMIC2",
>> +				"MIC BIAS1",
>> +				"VA DMIC3",
>> +				"MIC BIAS1",
>> +				"VA DMIC0",
>> +				"VA MIC BIAS3",
>> +				"VA DMIC1",
>> +				"VA MIC BIAS3",
>> +				"VA DMIC2",
>> +				"VA MIC BIAS1",
>> +				"VA DMIC3",
>> +				"VA MIC BIAS1",
>> +				"TX SWR_INPUT1",
>> +				"ADC2_OUTPUT";
> 
> It's good to write these entries in pairs, as that's what they
> correspond to.
> 
> Please also take a look at this commit:
> b49e37de8e70 ("arm64: dts: qcom: x1e80100-crd: Drop duplicate DMIC supplies")

Will update.

> 
> [...]
> 
>> +&i2c5 {
>> +	clock-frequency = <400000>;
>> +	status = "okay";
> 
> A '\n' before status is customary

Will update.

> 
> [...]
> 
>> +&usb_mp_hsphy0 {
>> +	phys = <&eusb6_repeater>;
>> +};
>> +
>> +&usb_mp_hsphy1 {
>> +	phys = <&eusb3_repeater>;
>> +};
> 
> See:
> 
> https://lore.kernel.org/linux-arm-msm/20250819-x1e80100-fix-usb-mp-repeaters-v1-4-0f8c186458d3@linaro.org/
> 

Great reminder! I'll take care of it.

> Konrad

-- 
Best Regards,
Yijie