From: Geliang Tang <geliangtang@gmail.com>
To: "Ed L. Cashin" <ed.cashin@acm.org>
Cc: Geliang Tang <geliangtang@gmail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] aoe: use setup_timer
Date: Fri, 24 Mar 2017 22:15:09 +0800 [thread overview]
Message-ID: <4841d2c2936addc27a2e774041d04ec16885ba03.1490341208.git.geliangtang@gmail.com> (raw)
Use setup_timer() instead of init_timer() to simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/block/aoe/aoemain.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/aoe/aoemain.c b/drivers/block/aoe/aoemain.c
index 4b987c2..20865d4 100644
--- a/drivers/block/aoe/aoemain.c
+++ b/drivers/block/aoe/aoemain.c
@@ -28,10 +28,8 @@ discover_timer(ulong vp)
switch (vp) {
case TINIT:
- init_timer(&t);
+ setup_timer(&t, discover_timer, TRUN);
spin_lock_init(&lock);
- t.data = TRUN;
- t.function = discover_timer;
die = 0;
case TRUN:
spin_lock_irqsave(&lock, flags);
--
2.9.3
next reply other threads:[~2017-03-24 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 14:15 Geliang Tang [this message]
2017-03-24 14:15 ` [PATCH] block: floppy: " Geliang Tang
2017-03-24 14:23 ` Jens Axboe
2017-03-24 14:15 ` [PATCH] drbd: " Geliang Tang
2017-03-24 14:15 ` [PATCH] ipmi_ssif: " Geliang Tang
2017-03-25 2:59 ` Corey Minyard
2017-03-24 14:15 ` [PATCH] mg_disk: " Geliang Tang
2017-03-24 14:15 ` [PATCH] x86/pci-calgary: " Geliang Tang
2017-03-31 8:24 ` [tip:x86/cleanups] x86/pci-calgary: Use setup_timer() instead of open coding it tip-bot for Geliang Tang
2017-03-25 19:32 ` [PATCH] aoe: use setup_timer Ed Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4841d2c2936addc27a2e774041d04ec16885ba03.1490341208.git.geliangtang@gmail.com \
--to=geliangtang@gmail.com \
--cc=ed.cashin@acm.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®